Skip to content

Resolving Voice Over issues with Links on Sidebar#474

Open
pratyush1712 wants to merge 20 commits into
masterfrom
ps2245/sidebar-links
Open

Resolving Voice Over issues with Links on Sidebar#474
pratyush1712 wants to merge 20 commits into
masterfrom
ps2245/sidebar-links

Conversation

@pratyush1712

@pratyush1712 pratyush1712 commented Oct 24, 2023

Copy link
Copy Markdown
Member

Summary

Home-Sidebar links
  • Reorganized usage of aria tags to prevent voice-over from announcing the link twice.
  • Added documentation for the truncate function used to shorten the notification message in the Message.tsx component.

@pratyush1712 pratyush1712 requested a review from a team as a code owner October 24, 2023 22:16
@dti-github-bot

dti-github-bot commented Oct 24, 2023

Copy link
Copy Markdown
Member

[diff-counting] Significant lines: 101.

@Atikpui007 Atikpui007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well
Old PR that needs merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants