Analytics Modal + CSV Bug Fix by anika-4444 · Pull Request #603 · cornell-dti/carriage-web

anika-4444 · 2025-10-27T01:56:48Z

Summary

This pull request is the first step towards implementing the analytics page

Implemented a modal for exporting CSV data. When 'Export Data' is pressed, a pop up appears prompting the user for the date range. When 'export' is pressed inside the pop up, a CSV link will be sent to downloads with ride data for that date range.
Fixed bug involving CSV downloaded data. Previously, null/bad data was sent as a CSV file the first time export was clicked. This issue is now fixed.
Added documentation for the stats backend

Testing

I did some preliminary manual tests and everything seemed to work. Using MUI DatePicker also helped with streamlining the date validation process. However, more in depth testing (by creating lots of rides with different characteristics such as if they are cancelled, no shows, at night, etc) will likely be needed once I fix backend querying (see below).

Notes

This is the first part of fixing the analytics page. Although CSV exporting now works, the analytics page does not query previous ride information (all the data currently is dummy data). My next step will be fixing the backend so that querying works correctly.

dti-github-bot · 2025-10-27T02:01:45Z

[diff-counting] Significant lines: 441.

benkoppe

Good work with these changes, but I think a bit more is needed to ensure proper usability and polish. See my comments about the modal options especially. Also be careful about things like dependencies in the package.json! I'm finding myself making mistakes like that more and more as I let AI automate commands. I hope these comments are overall useful!

benkoppe · 2025-10-27T03:37:04Z

  "description": "",
  "main": "index.js",
  "dependencies": {
+    "@emotion/react": "^11.14.0",


I don't think all of these dependencies are necessary, and all of them should be contained to the package.json of the frontend. For example, react is only needed by the frontend (and is probably already a dependency there, too).

benkoppe · 2025-10-27T03:39:28Z

+            <div className={styles.form}>
+              <LocalizationProvider dateAdapter={AdapterDayjs}>
+                <div style={{ marginBottom: '1rem', marginTop: '1.5rem' }}>
+                  <DatePicker


You might want to rethink how you handle the modal here. Using it on the website, I was frustrated that the date range I had set for the main analytics view didn't carry over to the default values on this modal. Maybe it could be a prop for the export button?

… CSV, added documentation to stats backend]

…modal

…date ranges

Error in AnalyticsTable: Warning: Maximum update depth exceeded. This can happen when a component calls setState inside useEffect, but useEffect either doesn't have a dependency array, or one of the dependencies changes on every render. Error in stats: trying to create an existing stat

mjaydenkim

unfortunately problems w/ the analytics backend are kinda prohibitive to testing this pr, lmk if that's something you wanna work on/if not id love to help like i said!!!

mjaydenkim · 2025-12-01T18:50:01Z

should these really be pushed?

mjaydenkim · 2025-12-02T01:29:02Z

-            driverData.push(driverRow);
-          }
-        });
+      sortedData.forEach((d) => {


i put in some changes to fix a warning about the maximum update depth being exceeded

mjaydenkim · 2025-12-02T01:31:22Z

 });

+/**
+ * GET


currently this is highly inefficient b/c it requests day by day -- requests over the medium to long term take a very long time to process

mjaydenkim · 2025-12-02T01:33:09Z

+ *
+ * response:
+ * - JSON array of computed or existing stats
+ */


right now when i try to request data from the backend i get the following error -- Populate failed for item { id: _____ } error: TypeError: Cannot read properties of undefined (reading 'getInternalProperties')
...
Error: Cannot set headers after they are sent to the client

style and stuff looks pretty good, and i know that the backend isn't your priority in this PR but these are problems that prevent me from using the page at all -- if you wanna fix them that'd be amazing ! but if you don't have the capacity/don't want to please feel free to hit me up b/c i already tried bugfixing this for a minute and i'd love to help out

@mjaydenkim Thanks for the feedback!! The error you get is something everyone seems to be facing when requesting data. We talked about it at the end of work session last week and it seems like it's a problem with AWS/DynamoDB. I was getting it a lot when I was working on creating custom rides and Ryan also mentioned something about it. Definitely something we need to look into but I'm not sure its specific to this PR

as for the rides logic problems, if you have time and want to help that would be great! there is a branch called stats-backend that I was using which has a lot of console logs to debug if you want to check that out.

one problem I was considering is updates and how to ensure they persist---if the stats table is based on information from the rides table, then the edit button for this page is essentially useless because what's recorded will be erased when the page is refreshed and the rides data (which will not be updated) is requested again.

i think the easiest solution to this would be to get rid of the update button and rely on drivers/admin to ensure rides have the correct statuses. because it might be infeasible for drivers to constantly press update, one idea I had was to have all rides automatically transition to completed after their end time occurs. because no shows are likely rare, having the admin go to the home page and update the individual ride (instead of just the stats table) should not be too much of a hassle.

that makes a lot of sense, i figured it was a broader issue -- i'll look into migrating backends cuz this is really annoying LOL. tysm for letting me know ! i was just apprehensive to sign off on the changes when they're currently difficult to test yk? also that's amazing i'll go into that branch and take a look

also i think you're right about the update button -- i don't imagine that admin would be trying consistently to edit rides from the analytics page too. i think transitioning to completed makes sense to me as a default end state too, that sounds good to me

mjaydenkim

did a second pass on the code line by line instead of focusing on testing the broken dynamodb stuff and it looks really good to me! the ui element modifications are great and so is the documentation !

mjaydenkim · 2025-12-02T16:57:29Z

exporting doesn't work for me b/c of the aforementioned errors but this code looks good to me !

mjaydenkim · 2025-12-02T16:58:16Z

 });

+/**
+ * PUT


good documentation!

anika-4444 requested a review from a team as a code owner October 27, 2025 01:56

anika-4444 changed the base branch from master to dka34/changes October 27, 2025 01:59

benkoppe reviewed Oct 27, 2025

View reviewed changes

Base automatically changed from dka34/changes to master November 2, 2025 21:57

anika-4444 added 7 commits November 21, 2025 18:03

Analytics Task Part 1 [added modal for data exporting, fixed bug with…

a3c7ff1

… CSV, added documentation to stats backend]

Removed unneeded dependencies from server package.json

afcc6ea

Added props to carry date range changes from analytics page to stats …

709dbdb

…modal

Cleaned up styling/imports, added shortcut buttons for commonly used …

fc11073

…date ranges

Changed button type to further separate styling

2629933

Prettier

b6a2e29

Env changes

5668b7a

anika-4444 force-pushed the analytics-modal branch from 0d64e90 to 5668b7a Compare November 22, 2025 00:50

mjaydenkim self-requested a review December 1, 2025 18:39

mjaydenkim requested changes Dec 2, 2025

View reviewed changes

mjaydenkim reviewed Dec 2, 2025

View reviewed changes

               });
+              /**
+               * GET

               });
+              /**
+               * PUT

Conversation

anika-4444 commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Notes

Uh oh!

dti-github-bot commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

benkoppe left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mjaydenkim left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mjaydenkim left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

anika-4444 commented Oct 27, 2025 •

edited

Loading

dti-github-bot commented Oct 27, 2025 •

edited

Loading