Replace Create React App with Vite#605
Closed
benkoppe wants to merge 10 commits into
Closed
Conversation
|
|
Contributor
Author
|
|
4 tasks
Contributor
Author
|
Member
|
[diff-counting] Significant lines: 6851. This diff might be too big! Developer leads are invited to review the code. |
Contributor
Author
|
The problems mentioned in the two comments above have been addressed. |
❌ Deploy Preview for carriage-web failed.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mjaydenkim
approved these changes
Mar 4, 2026
Contributor
|
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces CRA (Create React App) with Vite. Builds are significantly faster, especially in development mode, and Vite is generally more extensible and convenient. It also appears to be very useful for PR #604 due to its native typescript support (more testing needed).
This change was very easy to do and appears to have only upsides, so it might be a good idea to go forward with. However, it is also totally unnecessary in general (barring what's mentioned above about its native ts support), so any hesitation is understood.
But it would be nice, because seriously builds are so much faster. For example, wait time on an initial run of
npm run start/npm run devon a new branch went from ~30 seconds to instant.Test Plan
Tests with this change will need to be mostly manual, because Vite intends to work as a mostly transparent replacement for the same things once done by create react app.
Breaking Changes
npm run devrather thannpm run start..envmust be named to replace prefixREACT_APPwithVITEtestandeject, as I believe eject is only a create react app thing, and I didn't add Vitest.