Skip to content

Update Docker flow to support latest codebase#608

Closed
benkoppe wants to merge 9 commits into
masterfrom
bek76/docker
Closed

Update Docker flow to support latest codebase#608
benkoppe wants to merge 9 commits into
masterfrom
bek76/docker

Conversation

@benkoppe

@benkoppe benkoppe commented Nov 2, 2025

Copy link
Copy Markdown
Contributor

Summary

Carriage is deployed using Docker. However, the Docker flow doesn't follow best practices, nor has it been updated to support the latest version of the codebase. This PR addresses both of those issues:

  • add all new env vars to docker-compose.yml
  • convert Dockerfile to use multi-stage builds and npm ci
    • this change keeps the final image minimal with only the minimum necessary requirements
  • ensure builds work with these new changes
  • ensure we can still properly run CI and remote deployment with the new secret SSO certificate file

Breaking Changes

- Frontend env vars were previously args that were only available at build time. They are now part of the environment, making them available at both build and run time. (reverted)

  • Some secrets have been better included in the main .dockerignore. We should look more into adding lines from the nested .dockerignore files into the main one, since these nested files are ignored.
  • This PR also updates the package-lock.json files such that the npm ci commands in the Dockerfile work properly.

@benkoppe benkoppe requested a review from a team as a code owner November 2, 2025 23:04
@dti-github-bot

dti-github-bot commented Nov 2, 2025

Copy link
Copy Markdown
Member

[diff-counting] Significant lines: 78.

@mjaydenkim mjaydenkim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me! Nice fixes/cleaning up stuff. Not many notes

Comment thread Dockerfile
@benkoppe

Copy link
Copy Markdown
Contributor Author

I don't want to merge this yet, I'm going to look over my test deployment over the weekend to ensure I've set this up 100%.

@benkoppe

benkoppe commented Dec 8, 2025

Copy link
Copy Markdown
Contributor Author

This PR has been replaced by #631.

@benkoppe benkoppe closed this Dec 8, 2025
@benkoppe benkoppe deleted the bek76/docker branch December 9, 2025 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants