Update Docker flow to support latest codebase#608
Closed
benkoppe wants to merge 9 commits into
Closed
Conversation
Member
|
[diff-counting] Significant lines: 78. |
- this spacing is nice anyways
6415a12 to
1cd063a
Compare
mjaydenkim
approved these changes
Nov 14, 2025
mjaydenkim
left a comment
Contributor
There was a problem hiding this comment.
Looks pretty good to me! Nice fixes/cleaning up stuff. Not many notes
Contributor
Author
|
I don't want to merge this yet, I'm going to look over my test deployment over the weekend to ensure I've set this up 100%. |
Contributor
Author
|
This PR has been replaced by #631. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Carriage is deployed using Docker. However, the Docker flow doesn't follow best practices, nor has it been updated to support the latest version of the codebase. This PR addresses both of those issues:
npm ciBreaking Changes
- Frontend env vars were previously args that were only available at build time. They are now part of the environment, making them available at both build and run time.(reverted).dockerignore. We should look more into adding lines from the nested.dockerignorefiles into the main one, since these nested files are ignored.package-lock.jsonfiles such that thenpm cicommands in the Dockerfile work properly.