Skip to content

Standardize Docker CI to use ghcr#614

Merged
selenaliu1 merged 6 commits into
masterfrom
bek76/docker-ci
Nov 3, 2025
Merged

Standardize Docker CI to use ghcr#614
selenaliu1 merged 6 commits into
masterfrom
bek76/docker-ci

Conversation

@benkoppe

@benkoppe benkoppe commented Nov 3, 2025

Copy link
Copy Markdown
Contributor

Summary

The current CI uses ghcr for pull requests, and some DockerHub account for the tip of master. Should this PR be merged, the DockerHub account is ditched in favor of ghcr everywhere.

It also renames the workflow tracking master to "Continuous Deployment of Master" for clarity, as there is no longer a concept of "Staging". It adds github.repository_owner to the tags for both cd-workflow.yml and ci-container.yml, as this is our last chance to ensure the highest level of clarity possible in our Docker image names.

Finally, the PR cleans up usage of the docker-build-push.yml workflow to ensure our Actions work again, as secrets: inherit sadly cannot be mixed with declared secrets. The mixing of secrets is fixed with the standardization of ghcr as a Docker repository.

  • standardize ghcr usage in favor of DockerHub
  • clean up docker-build-push.yml to remove now-unnecessary registry/login inputs
  • add github.repository_owner to Docker image tags

@benkoppe benkoppe requested a review from a team as a code owner November 3, 2025 03:54
@dti-github-bot

dti-github-bot commented Nov 3, 2025

Copy link
Copy Markdown
Member

[diff-counting] Significant lines: 42.

@selenaliu1 selenaliu1 merged commit c6b75fa into master Nov 3, 2025
5 checks passed
@selenaliu1 selenaliu1 deleted the bek76/docker-ci branch November 3, 2025 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants