Standardize Docker CI to use ghcr#614
Merged
Merged
Conversation
Member
|
[diff-counting] Significant lines: 42. |
selenaliu1
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The current CI uses ghcr for pull requests, and some DockerHub account for the tip of
master. Should this PR be merged, the DockerHub account is ditched in favor of ghcr everywhere.It also renames the workflow tracking
masterto "Continuous Deployment of Master" for clarity, as there is no longer a concept of "Staging". It addsgithub.repository_ownerto the tags for bothcd-workflow.ymlandci-container.yml, as this is our last chance to ensure the highest level of clarity possible in our Docker image names.Finally, the PR cleans up usage of the
docker-build-push.ymlworkflow to ensure our Actions work again, assecrets: inheritsadly cannot be mixed with declared secrets. The mixing of secrets is fixed with the standardization of ghcr as a Docker repository.docker-build-push.ymlto remove now-unnecessary registry/login inputsgithub.repository_ownerto Docker image tags