Edit rider info modal#690
Conversation
✅ Deploy Preview for carriage-web ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
[diff-counting] Significant lines: 48. |
mjaydenkim
left a comment
mjaydenkim
left a comment
There was a problem hiding this comment.
Everything about the frontend here works perfectly for me and looks great, good work!
I'm not sure if you're replicating this but when I try to change any detail about myself and click "edit profile" I get a 409 error reading "a user with this NetID already exists". Do you know why this might be happening? Maybe we should try making a version of this PR that uses the new database to see if it's specifically a Dynamo problem or something related to the way the API calls are happening.
| closeModal(); | ||
| }; | ||
|
|
||
| // Modal closes first (submitData sets isSubmitted), then this effect fires the API call so the |
There was a problem hiding this comment.
Good work with the documentation!!!
| {errors.endDate?.type === 'validate' && ( | ||
| <p className={styles.error}>Invalid end time</p> | ||
| )} | ||
| {!isStudentEditing && ( |
There was a problem hiding this comment.
Modal UI interacts well and is responsive, nice stuff!
3 participants
Summary
This pull request is the first step towards implementing feature edit rider info