Add search to requirements sidebar - #917
Open
Destaq wants to merge 5 commits into
Open
Conversation
Member
|
[diff-counting] Significant lines: 89. |
Contributor
|
Visit the preview URL for this PR (updated for commit 5bd65a6): https://cornelldti-courseplan-dev--pr917-simon-sidebar-search-4guayc1c.web.app (expires Wed, 15 May 2024 23:33:37 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933 |
plumshum
reviewed
May 4, 2024
plumshum
left a comment
plumshum
left a comment
Collaborator
There was a problem hiding this comment.
Ooo I really like this search bar implementation. I didn't encounter any bugs using the search bar. I have a few suggestions about the front-end and design.
- Can we make the search box the same width as the course cards so it looks more aligned? The right end seems a bit off.
- If there are no courses that match what the user typed in the search bar, I think some sort of text should pop up instead, something like
No Courses Found. It's providing insights for the user as to what happened.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added search functionality to requirements sidebar. UI is based on that of
CourseSelector.vue.Test Plan
Look at the preview URL and play around with it.