potential save course fix - #964
Conversation
- default collection functionality changed - courses in default collection can only be removed by specifically removing that course from the default collection
|
[diff-counting] Significant lines: 21. |
|
Visit the preview URL for this PR (updated for commit f00b29a): https://cornelldti-courseplan-dev--pr964-savedcourses-fixes-hpuztrf4.web.app (expires Tue, 17 Dec 2024 22:25:47 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933 |
nidhi-mylavarapu
left a comment
There was a problem hiding this comment.
I know this is a draft PR so there are still some more fixes but great progress so far!! thanks so much for being on top of it!
|
|
||
| // If no specific collections were selected, and no prevoius selections were removed, add to 'All' | ||
| if (addedToCollections.length === 0 && deletedFromCollections.length === 0) { | ||
| console.log('added to All'); |
There was a problem hiding this comment.
Just to clarify the functionality:
anytime you save any course, it should end up in the "all" collection, whether you add it to another specific collection or not?
There was a problem hiding this comment.
Also, on a completely separate note, should the other drop downs for collections close if you open a different one? That is, is it possible for all of the collection drop downs to be open at the same time?
Summary
This pull request is the first step potentially fixing save Courses default collection functionality
Test Plan
Notes
May not change the functionality based on future user reviews
Blockers
Breaking Changes