Nigels landing page #983
Open
Nigels landing page #983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 1208. This diff might be too big! Developer leads are invited to review the code. |
nidhi-mylavarapu
approved these changes
Mar 20, 2025
|
Visit the preview URL for this PR (updated for commit a96a738): https://cornelldti-courseplan-dev--pr983-nigels-landing-page-bkmk00fh.web.app (expires Fri, 16 May 2025 01:13:09 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933 |
nidhi-mylavarapu
requested changes
Mar 23, 2025
ejcheng
reviewed
Mar 24, 2025
There was a problem hiding this comment.
Yeah, to add to Nidhi's comments, to fix the scaling issues, I think good first steps would be:
- Instead of using the explicit pixel values (which don't scale well on mobile/different aspect ratio screen sizes), use CSS flexbox.
- Some of the transform properties, especially when combined with absolute pixel values, can contribute to the "text off the page" issue, depending on the device you use. I'm not too well-versed in this, but I think changing your approach to not use
transformwould be better. - Adding media queries to explicitly target mobile devices— the current ones only apply the CSS properties under them to devices with a breakpoint of "large" or under
I think we should definitely discuss this during the next CoursePlan standup/work sesh, this is a pretty complicated frontend design and getting the CSS just right for this is going to be difficult.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Look at closed pr #976