WIP: implement quality-of-life changes for pre-enroll #995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 64. |
|
Visit the preview URL for this PR (updated for commit 9521050): https://cornelldti-courseplan-dev--pr995-qol-changes-preenrol-5kc7oo53.web.app (expires Wed, 14 May 2025 06:12:33 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933 |
…olor collision there probably is a better approach, but this is what i've come up with so far
ejcheng
commented
Apr 14, 2025
Comment on lines
+4
to
+8
| :style="{ | ||
| background: `#${Math.floor(Math.random() * 0xffffff) | ||
| .toString(16) | ||
| .padEnd(6, '0')}`, | ||
| }" |
There was a problem hiding this comment.
@cornell-dti/course-plan What do you think of this approach to ensure that no two tabs have the same color? It seems pretty questionable to me, but this is the best approach I could come up with for now.
I think this was mentioned in Clemént's design audit for accessibility reasons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://cornelldti.slack.com/archives/C05QHNY8TKL/p1744242627568859
Thanks @ambers7!
TODO:
RequirementFulfillmentGraph.getConnectedRequirementsFromCourse()to add the requirement(s) a course satisfies to its course card in the semester plan