Cleaned up onboarding flow and removed match card placeholders - #122
Conversation
✅ Deploy Preview for redi-love ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
clementroze
left a comment
clementroze
left a comment
There was a problem hiding this comment.
noice! thanks for cleaning up Gillio donde esta
| </View> | ||
| ); | ||
| // case 9: | ||
| // return ( |
There was a problem hiding this comment.
yay for shortening onboarding!
abrar-amin
left a comment
abrar-amin
left a comment
There was a problem hiding this comment.
Looks pretty good; SonarQube does not like commented code, so if we can get rid of it that would be great (I think that's the only reason why it fails the quality gate)
| ); | ||
| const [userAnswer, setUserAnswer] = useState<string>(''); | ||
| const [currentMatches, setCurrentMatches] = useState<MatchWithProfile[]>([]); | ||
| // ── TEMPORARY PLACEHOLDER ──────────────────────────────────────────────────── |
There was a problem hiding this comment.
Yippee no more temp data!
| try { | ||
| let prompt: WeeklyPromptResponse | null = null; | ||
|
|
||
| // TODO: wire up the answer-prompt header button once the weekly prompt |
There was a problem hiding this comment.
Maybe get rid of this TODO?
| </View> | ||
| )} | ||
| // case 12: | ||
| // return ( |
There was a problem hiding this comment.
We may want to delete these lines of code.
|
|
I think you're good to merge |
3 participants
Summary
Took training wheels off Match Cards (Following up on my implementation in Clement's 'swiping' PR):
Removed the following fields from onboarding to be re-introduced as profile action cards later:
-Ethnicity: multi-select ethnicity options
-Prompts: 1-3 draggable prompt selectors with question + answer
-Clubs: Cornell clubs/organizations tags
-Social links: Instagram, Snapchat, LinkedIn, GitHub, personal website
-Interests: free-text interest tags
Updated backend api specification
Fixed onboarding "Next" button permanently disabled from step 9 onward — updated validateStep and handleNext/TOTAL_STEPS to reflect the 10 active steps
Test Plan
Open the Home tab — confirm only real weekly match cards appear (no chat contacts or mock cards)
Go through the onboarding flow — confirm "Next" button works through all 10 steps without getting stuck
Notes
Next Steps:
Once the profile cards are done, the removed onboarding fields will be surfaced as profile action cards in the Home tab feed so users can fill them out post-signup
See onboarding demo here:
https://github.com/user-attachments/assets/76e94f2f-30da-41fc-a733-2d12881035fa