Skip to content

Deprecating length_safe_zip in favor of zip(..., strict=True)#2718

Merged
kayween merged 1 commit into
cornellius-gp:mainfrom
SebastianAment:replace-length-safe-zip
Feb 20, 2026
Merged

Deprecating length_safe_zip in favor of zip(..., strict=True)#2718
kayween merged 1 commit into
cornellius-gp:mainfrom
SebastianAment:replace-length-safe-zip

Conversation

@SebastianAment
Copy link
Copy Markdown
Contributor

zip supports strict since Python 3.10, which appears to be GPyTorch's version floor, so we can start relying on the core implementation, simplifying the implementation.

Copy link
Copy Markdown
Collaborator

@Balandat Balandat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but please rebase once #2715 has landed so the PR only contains the incremental changes.

@SebastianAment SebastianAment force-pushed the replace-length-safe-zip branch from e962a58 to 38980ec Compare February 20, 2026 20:00
@SebastianAment
Copy link
Copy Markdown
Contributor Author

@Balandat @kayween This should be ready now as well.

@kayween kayween merged commit f2ef2a5 into cornellius-gp:main Feb 20, 2026
7 checks passed
@SebastianAment SebastianAment deleted the replace-length-safe-zip branch February 20, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants