Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add render to canvas for mpr/volume viewports #1215

Merged
merged 5 commits into from
May 28, 2024

Conversation

wayfarer3130
Copy link
Collaborator

Context

The render to canvas did not have the ability to render volume views. This PR adds that capability.

Changes & Results

Add render using volume viewport
Add a number of fixes for positioning using the setView position, and for sizing/positioning of views.

Testing

Run the renderToCanvas example

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

@wayfarer3130 wayfarer3130 requested a review from sedghi April 18, 2024 22:01
Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit 03437b2
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/664cb4b005652400083fbc88
😎 Deploy Preview https://deploy-preview-1215--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already reviewed this elsewhere, so looks good

@sedghi sedghi merged commit e400277 into main May 28, 2024
10 checks passed
@sedghi sedghi deleted the feat/loadImageToCanvas-volume branch January 22, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants