Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flip): seperate flip calls #1868

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(flip): seperate flip calls #1868

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/core/src/RenderingEngine/Viewport.ts
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can flip not take null as a value?

Original file line number Diff line number Diff line change
Expand Up @@ -1881,8 +1881,11 @@ class Viewport {
// right now if the view presentation requires a flip, it will flicker. The
// correct way to handle this is to wait for camera and flip together and then
// do one render
if (flipHorizontal || flipVertical) {
this.flip({ flipHorizontal, flipVertical });
if (flipHorizontal !== undefined) {
this.flip({ flipHorizontal });
}
if (flipVertical !== undefined) {
this.flip({ flipVertical });
}
}

Expand Down
Loading