Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(segmentation): resolve variable declaration and null check issues #1872

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Mar 4, 2025

  • Fixed variable redeclaration in ensureImageVolume.ts
  • Updated null checks in getStrategyData.ts to use more robust comparison

Context

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

* Fixed variable redeclaration in `ensureImageVolume.ts`
* Updated null checks in `getStrategyData.ts` to use more robust comparison
Copy link

netlify bot commented Mar 4, 2025

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit c045e75
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/67c67b5eaec8e80008542c55
😎 Deploy Preview https://deploy-preview-1872--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sedghi sedghi merged commit 029966d into main Mar 4, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant