Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(worker): should not change type of input #1877

Merged
merged 1 commit into from
Mar 5, 2025
Merged

fix(worker): should not change type of input #1877

merged 1 commit into from
Mar 5, 2025

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Mar 5, 2025

This pull request includes several changes to improve the efficiency and performance of the CentralizedWorkerManager class and to clean up the displayStat function. The most important changes include removing unused options and redundant code.

Improvements to CentralizedWorkerManager:

  • Removed the options property from the worker initialization as it was not being used. (packages/core/src/webWorkerManager/webWorkerManager.js)
  • Removed the augmentation of args with workerProperties.options in the worker method call, as this was unnecessary. (packages/core/src/webWorkerManager/webWorkerManager.js)

Code cleanup in displayStat function:

  • Removed the unused viewport variable from the calculateStatistics function. (packages/tools/examples/labelmapStatistics/index.ts)

Copy link

netlify bot commented Mar 5, 2025

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit b4ed380
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/67c887c983fa2700080cca9e
😎 Deploy Preview https://deploy-preview-1877--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sedghi sedghi merged commit a97effd into main Mar 5, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant