feat(segmentStatsCalculator): for calculation of statistics #1881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…individual and collective modes This commit introduces a more flexible approach to calculating segmentation statistics by: - Adding a new SegmentStatsCalculator to manage segment-specific statistics - Supporting both 'individual' and 'collective' computation modes - Refactoring VolumetricCalculator and BasicStatsCalculator to support more dynamic statistical analysis - Updating segmentation statistics worker to use the new calculation method - Improving example code to demonstrate new statistics calculation features
…at/multi-getStats
✅ Deploy Preview for cornerstone-3d-docs canceled.
|
sedghi
changed the title
wayfarer3130
reviewed
Mar 7, 2025
| } | ||
| ): NamedStatistics { | ||
| const { spacing } = options; | ||
| const volumeUnit = spacing ? 'mm³' : 'voxels³'; |
There was a problem hiding this comment.
Please add methods to getCalibratedLengthUnitsAndScale to get the appropriate volume unit. Also, voxel is the unit, voxels^3 would be a 9 dimensional hyper cube.
…tion statistics - Add volume unit and calibration support to getCalibratedLengthUnitsAndScale - Update VolumetricCalculator and SegmentStatsCalculator to include calibration and pixel spacing options - Improve volume statistics calculation with more flexible unit and scaling
There was a problem hiding this comment.
PR Overview
This PR introduces an instantiable segment statistics calculator to compute statistics for segmentation data either collectively or individually. Key changes include:
- Adding a new class (SegmentStatsCalculator) to create and manage per‐segment or combined volumetric calculators.
- Adapting the compute worker and related utility functions to work with the new calculator API.
- Refactoring existing basic statistics calculators and updating examples and helpers to support the new mode parameter.
Reviewed Changes
| File | Description |
|---|---|
| packages/tools/src/utilities/segmentation/SegmentStatsCalculator.ts | New class to manage individual and collective segment statistics |
| packages/tools/src/utilities/segmentation/VolumetricCalculator.ts | Refactored state management and statistics calculation for volumes |
| packages/tools/src/utilities/segmentation/getStatistics.ts | Added mode parameter handling (collective vs individual) |
| packages/tools/examples/labelmapStatistics/index.ts | Updated UI to include direct control for individual/collective modes |
| packages/tools/src/utilities/math/basic/BasicStatsCalculator.ts | Refactored to use a state-based approach for accumulating stats |
| packages/tools/src/workers/computeWorker.js | Switched to using SegmentStatsCalculator in place of VolumetricCalculator |
| packages/tools/src/utilities/getCalibratedUnits.ts | Updated to provide calibrated volume units |
| packages/tools/src/utilities/segmentation/index.ts | Updated exports to include the new SegmentStatsCalculator |
Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.
…at/multi-getStats
This commit adds screenshot test images for various segmentation tools (circular brush, scissor, eraser, and sphere brush) across Chromium and WebKit browsers. It also removes two deprecated threshold brush tests for bone and fat segmentation.
sedghi
force-pushed
the
feat/multi-getStats
branch
from
921e458 to
7030468
Compare
wayfarer3130
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing Instantiable Calculators
Sometimes, a static calculator just isn't enough. For example, if you want to loop through all the labelmap data and calculate statistics for each segment, you'll need to use separate calculators for each one.
Segment Statistics Calculation:
SegmentStatsCalculatorto manage statistics for multiple segments, supporting both individual and collective modes for more versatile statistics calculations.