Skip to content

feat: Add shared languages as a bonus during matching process#1299

Merged
JeangelLF merged 4 commits intomasterfrom
feat/include-languages-as-matching-bonus
Dec 8, 2025
Merged

feat: Add shared languages as a bonus during matching process#1299
JeangelLF merged 4 commits intomasterfrom
feat/include-languages-as-matching-bonus

Conversation

@JeangelLF
Copy link
Contributor

Ticket

Resolves https://github.com/corona-school/project-user/issues/1553

What was done?

  • Included a bonus for shared languages in the matching-algo
  • Updated tests

@realmayus realmayus temporarily deployed to backend-feat-include-la-o62p05 October 30, 2025 09:10 Inactive
Jonasdoubleyou
Jonasdoubleyou previously approved these changes Oct 30, 2025
Copy link
Member

@Jonasdoubleyou Jonasdoubleyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether this has any effect at all - is there any realistic language overlap? Do we have many users that have maintained other languages?

@JeangelLF
Copy link
Contributor Author

I wonder whether this has any effect at all - is there any realistic language overlap? Do we have many users that have maintained other languages?

With the new registration flow the new users can now indicate which languages they speak or can help with. We’ve also added a language update step in the match request process on the user app, so profiles stay up to date. The hope is that this will have a bigger impact, especially for pupils who don’t speak German.

Copy link
Member

@Jonasdoubleyou Jonasdoubleyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For it to have a bigger impact it has to be a constraint (causing the inverse effect that users stay in the pool for a long time) - the score is more or less useless as the number of users in the pool is low

@JeangelLF
Copy link
Contributor Author

JeangelLF commented Nov 10, 2025

With this implementation, suppose there’s a pupil who needs help in DaZ and has indicated that they speak Turkish.

If there are two students offering DaZ support, and one of them also has Turkish in their profile, we would try to match that student with the pupil, correct?

If so, I think this may be enough for now.

@JeangelLF JeangelLF marked this pull request as ready for review November 11, 2025 15:10
@JeangelLF JeangelLF temporarily deployed to backend-feat-include-la-o62p05 November 11, 2025 15:11 Inactive
@JeangelLF JeangelLF merged commit b7a4b1b into master Dec 8, 2025
2 checks passed
@JeangelLF JeangelLF deleted the feat/include-languages-as-matching-bonus branch December 8, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants