Skip to content

Conversation

@geedo0
Copy link
Contributor

@geedo0 geedo0 commented Jan 6, 2026

Issue #, if available: 2907583

Description of changes:

This PR adds continuous integration testing against the latest AWS-LC commit to proactively detect compatibility issues. ACCP's CI testing previously only built against a pinned AWS-LC submodule commit. This meant potential integration failures with newer AWS-LC releases were discovered asynchronously and out-of-band, making them harder to track and address.

Adds a --latest-awslc flag to the run_accp_basic_tests.sh CI script that:

  • Clones the main branch of AWS-LC at test time instead of using the checked-in submodule
  • Overrides the CMake build to use the freshly cloned AWS-LC source
  • Enables testing against the tip of AWS-LC to catch breaking changes early

Testing

Ran the tests locally with the new flag.

./tests/ci/run_accp_basic_tests.sh --latest-awslc

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This ensures that ACCP continues to compile and pass tests when built
using the latest possible AWS-LC source code.
@geedo0 geedo0 marked this pull request as ready for review January 6, 2026 16:14
@geedo0 geedo0 requested a review from a team as a code owner January 6, 2026 16:14
@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@23490ed). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #511   +/-   ##
=======================================
  Coverage        ?   77.50%           
  Complexity      ?     1126           
=======================================
  Files           ?      118           
  Lines           ?     7156           
  Branches        ?      910           
=======================================
  Hits            ?     5546           
  Misses          ?     1123           
  Partials        ?      487           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants