fix: add wildcard route with redirect to root#72
Conversation
Navigating to an unknown URL (e.g., /nonexistent) showed an empty outlet with no user feedback. Add a catch-all ** route inside ShellComponent's children that redirects to the welcome page. Adds 2 route-config tests verifying the wildcard exists and is last. Fixes #71 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Review: LGTM ✓ Clean, minimal change. The wildcard route with The two route-level tests verify both the redirect target and the positioning — straightforward and sufficient. Ready to merge. |
|
Could not retrieve PR diff for security validation This PR requires manual review before merging. |
2 similar comments
|
Could not retrieve PR diff for security validation This PR requires manual review before merging. |
|
Could not retrieve PR diff for security validation This PR requires manual review before merging. |
Summary
**route insideShellComponentchildren that redirects unknown URLs to the welcome pageFixes #71
Test plan
ng test --no-watchpasses (385 tests, 18 files)npx tsc --noEmitpasses/nonexistent— should redirect to welcome page🤖 Generated with Claude Code