Autosave state & allow opting out - #229
Open
Carifio24 wants to merge 20 commits into
Open
Conversation
…ocal storage but not for exported files.
Carifio24
marked this pull request as ready for review
July 14, 2026 20:32
Member
Author
|
I've added a dialog to allow the user to opt out of local storage saving. I've also updated things so that local storage data is compressed, but exported data files are not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is intended to resolve #215. The current implementation sets up the app to save the state every 1 minute (60,000 ms), provided that the value of
useLocalStorageis true. It also respects the cache-disabling query parameter.Whether or not to save the state in local storage is a flag stored (somewhat ironically) in local storage - I don't really know where else we can put it. If a user changes their preference to not store the state in local storage, we remove the current state value in addition to preventing future saves (at least until the value is changed).
I haven't implemented any sort of UI for this yet. @patudom do we want this to show up on some sort of initial splash screen, or a small popup like our other data collection opt-out boxes? I assume that people who want this disabled would prefer that we actively ask them, rather than just having it stashed in a menu somewhere.