Wrkship fix 2 - #263
Open
johnarban wants to merge 25 commits into
Open
Conversation
…sion of the fill is possible but would need some color math)
johnarban
force-pushed
the
wrkship-fix-2
branch
from
August 6, 2026 20:20
afe8e53 to
7d81342
Compare
patudom
marked this pull request as ready for review
August 6, 2026 20:20
Contributor
|
- make sure the drawn layer changes by updating the paint properties - to make it easier to connect region and layer, give the layer/source the same id as the region
- have to place the button inside a div since tooltip does not activate on a disabled button
… it is easier to edit and maintain. prep for using a caret expanding panel for both
…d allow scrolling. the problem is there is no way to know you can scroll
- fix broken dataset check with was always truthy - hook up the sample errors which were doing nothing - enable retrying the dataset (and fix possible issues with _boundaries cache)
- demphasize cancel selection - clear -> uncheck all - disable graph datasets until something is checked
…so allow graphing and hide duplicate trash bin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements fixes from the workshop
address shepherd.js tour for data layers panel #262, with tour step gated on having regions. (no actual tour text yet). Uses what @Carifio24 did in Utilities for creating Shepherd tours vue-toolkit#118(moved to a new branch)Fix #256 Fix #260