Save command#158
Open
solarkraft wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
@splitbrain or @annda, would you mind having a look at this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to save the document using Ctrl/Cmd+Enter. This combination is already bound to hard_break:insert (hence the chaining), but it has Shift-Enter as well, so no functionality is lost.
I couldn't find a better way to save the document than selecting for the button in the DOM, but would happily change it to a better way if shown one.
Whether the document should be saveable without changes is debatable. The common implementations seem to differ and Dokuwiki already handles this case without creating a new revision.