Skip to content

action.php: isset check for $meta['last_change']['date'] @ handle_recent #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

action.php: isset check for $meta['last_change']['date'] @ handle_recent #36

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
44c8781
Illegal string offset '_elem' in action.php on line 205
hh-lohmann May 21, 2014
615f665
Illegal string offset '_elem' in action.php on line 231 (or 232)
hh-lohmann May 21, 2014
531c2c8
Illegal string offset '_elem' in action.php on line 205 - CORRECTION
hh-lohmann May 21, 2014
d115060
Illegal string offset '_elem' in action.php on line 231 (or 232) - CO…
hh-lohmann May 21, 2014
d52c4d0
action.php: isset check for $meta['last_change']['date'] @ handle_recent
ErikCan May 26, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 33 additions & 27 deletions action.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,8 +202,10 @@ function handle_revisions(&$event, $param) {

$member = null;
foreach($event->data->_content as $key => $ref) {
if($ref['_elem'] == 'opentag' && $ref['_tag'] == 'div' && $ref['class'] == 'li') {
$member = $key;
if(isset($ref['_elem']) && isset($ref['_tag']) && isset($ref['class'])) {
if($ref['_elem'] == 'opentag' && $ref['_tag'] == 'div' && $ref['class'] == 'li') {
$member = $key;
}
}

if($member && $ref['_elem'] == 'tag' &&
Expand All @@ -228,35 +230,39 @@ function handle_recent(&$event, $param) {

$member = null;
foreach($event->data->_content as $key => $ref) {
if($ref['_elem'] == 'opentag' && $ref['_tag'] == 'div' && $ref['class'] == 'li') {
$member = $key;
}
if(isset($ref['_elem']) && isset($ref['_tag']) && isset($ref['class'])) {
if($ref['_elem'] == 'opentag' && $ref['_tag'] == 'div' && $ref['class'] == 'li') {
$member = $key;
}

if($member && $ref['_elem'] == 'opentag' &&
$ref['_tag'] == 'a' && $ref['class'] == 'diff_link'){
$name = $ref['href'];
$name = explode('?', $name);
$name = explode('&', $name[1]);
$usename = null;
foreach($name as $n) {
$fields = explode('=', $n);
if($fields[0] == 'id') {
$usename = $fields[1];
break;
if($member && $ref['_elem'] == 'opentag' &&
$ref['_tag'] == 'a' && $ref['class'] == 'diff_link'){
$name = $ref['href'];
$name = explode('?', $name);
$name = explode('&', $name[1]);
$usename = null;
foreach($name as $n) {
$fields = explode('=', $n);
if($fields[0] == 'id') {
$usename = $fields[1];
break;
}
}
}
if($usename) {
if($this->hlp->in_namespace($this->getConf('apr_namespaces'), $usename)) {
$meta = p_get_metadata($usename);

if($meta['approval'][$meta['last_change']['date']]) {
$event->data->_content[$member]['class'] = 'li approved_revision';
}else{
$event->data->_content[$member]['class'] = 'li unapproved_revision';
if($usename) {
if($this->hlp->in_namespace($this->getConf('apr_namespaces'), $usename)) {
$meta = p_get_metadata($usename);

if ( isset ( $meta['last_change']['date'] ) ) {
if($meta['approval'][$meta['last_change']['date']]) {
$event->data->_content[$member]['class'] = 'li approved_revision';
}else{
$event->data->_content[$member]['class'] = 'li unapproved_revision';
}
}
}
}
}
$member = null;
}
$member = null;
}
}
return true;
Expand Down