fix(NuGet): prevent duplicate installedApps by keeping the highest version#218
Merged
fix(NuGet): prevent duplicate installedApps by keeping the highest version#218
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes duplicate installedApps entries by implementing version-based deduplication logic, keeping only the highest version when multiple apps with the same ID are found.
Changes:
- Added deduplication logic in the InstalledAppsPath processing to prevent duplicate app entries with the same ID
- Implemented version comparison to retain the highest version when duplicates are detected
Comments suppressed due to low confidence (1)
artifacts/ArtifactHandling/NuGet/Invoke-NuGetPackageDownload.ps1:165
- The predefinedPackages section (lines 116-166) doesn't apply the same duplicate detection logic as the InstalledAppsPath section. If predefined packages can contain duplicates or conflict with each other, they should use the same deduplication approach for consistency.
$downloadParameters.installedApps += $installedApp
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
artifacts/ArtifactHandling/NuGet/Invoke-NuGetPackageDownload.ps1
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
artifacts/ArtifactHandling/NuGet/Invoke-NuGetPackageDownload.ps1:166
- After deduplicating installedApps from the InstalledAppsPath (line 114), the predefinedPackages loop still uses the += operator which can potentially reintroduce duplicates if multiple predefined packages share the same ID. Consider applying the same deduplication pattern here by checking if an app with the same ID already exists before adding, or by collecting all apps in the appsById hashtable and converting to array once at the end.
$downloadParameters.installedApps += $installedApp
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ChrisBlankDe
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Duplicate entries in the installedApps cause an error in BCCH when downloading NuGet packages.
fixes AB#4615