chore: add `x/protocolpool` #23933

aljo242 · 2025-03-07T19:17:40Z

keeping as a draft

add module
add proto
add to legacy and di applications
update readme
add legacy amino
make compatible with v53

TODO:

reintegrate sims
get all fixes into x/distr
add switchover logic to x/distr

github-advanced-security

gosec found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

x/protocolpool/module.go

+func (am AppModule) BeginBlock(ctx context.Context) error {
+	sdkCtx := sdk.UnwrapSDKContext(ctx)
+
+	return am.keeper.BeginBlocker(sdkCtx)


github-actions · 2025-03-18T15:38:43Z

⚠️ govulncheck found vulnerabilities:

mkdir -p /home/runner/work/cosmos-sdk/cosmos-sdk/build/
GOBIN=/home/runner/work/cosmos-sdk/cosmos-sdk/build go install golang.org/x/vuln/cmd/govulncheck@latest
go: downloading golang.org/x/vuln v1.1.4
go: downloading golang.org/x/telemetry v0.0.0-20240522233618-39ace7a40ae7
go: downloading golang.org/x/mod v0.22.0
go: downloading golang.org/x/tools v0.29.0
/home/runner/work/cosmos-sdk/cosmos-sdk/build/govulncheck ./...
=== Symbol Results ===

Vulnerability #1: GO-2025-3443
    CometBFT allows a malicious peer to stall the network by disseminating
    seemingly valid block parts in github.com/cometbft/cometbft
  More info: https://pkg.go.dev/vuln/GO-2025-3443
  Module: github.com/cometbft/cometbft
    Found in: github.com/cometbft/[email protected]
    Fixed in: github.com/cometbft/[email protected]
    Example traces found:
      #1: testutil/network/util.go:74:24: network.startInProcess calls service.BaseService.Start, which eventually calls types.Part.ValidateBasic
      #2: testutil/network/util.go:74:24: network.startInProcess calls service.BaseService.Start, which eventually calls types.Part.ValidateBasic
      #3: client/rpc/block.go:56:36: rpc.QueryBlocks calls local.Local.BlockSearch, which eventually calls types.PartFromProto
      #4: client/rpc/block.go:56:36: rpc.QueryBlocks calls local.Local.BlockSearch, which eventually calls types.PartFromProto

Your code is affected by 1 vulnerability from 1 module.
This scan also found 0 vulnerabilities in packages you import and 2
vulnerabilities in modules you require, but your code doesn't appear to call
these vulnerabilities.
Use '-show verbose' for more details.
make: *** [Makefile:155: vulncheck] Error 3

github-actions · 2025-03-19T18:54:28Z

    ⚠️ **govulncheck found vulnerabilities:**


    >mkdir -p /home/runner/work/cosmos-sdk/cosmos-sdk/build/

GOBIN=/home/runner/work/cosmos-sdk/cosmos-sdk/build go install golang.org/x/vuln/cmd/govulncheck@latest
go: downloading golang.org/x/vuln v1.1.4
go: downloading golang.org/x/telemetry v0.0.0-20240522233618-39ace7a40ae7
go: downloading golang.org/x/mod v0.22.0
go: downloading golang.org/x/tools v0.29.0
/home/runner/work/cosmos-sdk/cosmos-sdk/build/govulncheck ./...
=== Symbol Results ===

Vulnerability #1: GO-2025-3443
CometBFT allows a malicious peer to stall the network by disseminating
seemingly valid block parts in github.com/cometbft/cometbft
More info: https://pkg.go.dev/vuln/GO-2025-3443
Module: github.com/cometbft/cometbft
Found in: github.com/cometbft/[email protected]
Fixed in: github.com/cometbft/[email protected]
Example traces found:
#1: testutil/network/util.go:74:24: network.startInProcess calls service.BaseService.Start, which eventually calls types.Part.ValidateBasic
#2: testutil/network/util.go:74:24: network.startInProcess calls service.BaseService.Start, which eventually calls types.Part.ValidateBasic
#3: client/rpc/block.go:56:36: rpc.QueryBlocks calls local.Local.BlockSearch, which eventually calls types.PartFromProto
#4: client/rpc/block.go:56:36: rpc.QueryBlocks calls local.Local.BlockSearch, which eventually calls types.PartFromProto

Your code is affected by 1 vulnerability from 1 module.
This scan also found 0 vulnerabilities in packages you import and 2
vulnerabilities in modules you require, but your code doesn't appear to call
these vulnerabilities.
Use '-show verbose' for more details.
make: *** [Makefile:155: vulncheck] Error 3

github-actions · 2025-03-19T19:05:10Z

    ⚠️ **govulncheck found vulnerabilities:**


    >mkdir -p /home/runner/work/cosmos-sdk/cosmos-sdk/build/

GOBIN=/home/runner/work/cosmos-sdk/cosmos-sdk/build go install golang.org/x/vuln/cmd/govulncheck@latest
go: downloading golang.org/x/vuln v1.1.4
go: downloading golang.org/x/telemetry v0.0.0-20240522233618-39ace7a40ae7
go: downloading golang.org/x/mod v0.22.0
go: downloading golang.org/x/tools v0.29.0
/home/runner/work/cosmos-sdk/cosmos-sdk/build/govulncheck ./...
=== Symbol Results ===

Vulnerability #1: GO-2025-3443
CometBFT allows a malicious peer to stall the network by disseminating
seemingly valid block parts in github.com/cometbft/cometbft
More info: https://pkg.go.dev/vuln/GO-2025-3443
Module: github.com/cometbft/cometbft
Found in: github.com/cometbft/[email protected]
Fixed in: github.com/cometbft/[email protected]
Example traces found:
#1: testutil/network/util.go:74:24: network.startInProcess calls service.BaseService.Start, which eventually calls types.Part.ValidateBasic
#2: testutil/network/util.go:74:24: network.startInProcess calls service.BaseService.Start, which eventually calls types.Part.ValidateBasic
#3: client/rpc/block.go:56:36: rpc.QueryBlocks calls local.Local.BlockSearch, which eventually calls types.PartFromProto
#4: client/rpc/block.go:56:36: rpc.QueryBlocks calls local.Local.BlockSearch, which eventually calls types.PartFromProto

Your code is affected by 1 vulnerability from 1 module.
This scan also found 0 vulnerabilities in packages you import and 2
vulnerabilities in modules you require, but your code doesn't appear to call
these vulnerabilities.
Use '-show verbose' for more details.
make: *** [Makefile:155: vulncheck] Error 3

github-actions · 2025-03-19T19:41:50Z

    ⚠️ **govulncheck found vulnerabilities:**


    >mkdir -p /home/runner/work/cosmos-sdk/cosmos-sdk/build/

GOBIN=/home/runner/work/cosmos-sdk/cosmos-sdk/build go install golang.org/x/vuln/cmd/govulncheck@latest
go: downloading golang.org/x/vuln v1.1.4
go: downloading golang.org/x/telemetry v0.0.0-20240522233618-39ace7a40ae7
go: downloading golang.org/x/mod v0.22.0
go: downloading golang.org/x/tools v0.29.0
/home/runner/work/cosmos-sdk/cosmos-sdk/build/govulncheck ./...
=== Symbol Results ===

Vulnerability #1: GO-2025-3443
CometBFT allows a malicious peer to stall the network by disseminating
seemingly valid block parts in github.com/cometbft/cometbft
More info: https://pkg.go.dev/vuln/GO-2025-3443
Module: github.com/cometbft/cometbft
Found in: github.com/cometbft/[email protected]
Fixed in: github.com/cometbft/[email protected]
Example traces found:
#1: testutil/network/util.go:74:24: network.startInProcess calls service.BaseService.Start, which eventually calls types.Part.ValidateBasic
#2: testutil/network/util.go:74:24: network.startInProcess calls service.BaseService.Start, which eventually calls types.Part.ValidateBasic
#3: client/rpc/block.go:56:36: rpc.QueryBlocks calls local.Local.BlockSearch, which eventually calls types.PartFromProto
#4: client/rpc/block.go:56:36: rpc.QueryBlocks calls local.Local.BlockSearch, which eventually calls types.PartFromProto

Your code is affected by 1 vulnerability from 1 module.
This scan also found 0 vulnerabilities in packages you import and 2
vulnerabilities in modules you require, but your code doesn't appear to call
these vulnerabilities.
Use '-show verbose' for more details.
make: *** [Makefile:155: vulncheck] Error 3

github-actions · 2025-03-20T13:52:09Z

    ⚠️ **govulncheck found vulnerabilities:**


    >mkdir -p /home/runner/work/cosmos-sdk/cosmos-sdk/build/

GOBIN=/home/runner/work/cosmos-sdk/cosmos-sdk/build go install golang.org/x/vuln/cmd/govulncheck@latest
go: downloading golang.org/x/vuln v1.1.4
go: downloading golang.org/x/telemetry v0.0.0-20240522233618-39ace7a40ae7
go: downloading golang.org/x/mod v0.22.0
go: downloading golang.org/x/tools v0.29.0
/home/runner/work/cosmos-sdk/cosmos-sdk/build/govulncheck ./...
=== Symbol Results ===

Vulnerability #1: GO-2025-3443
CometBFT allows a malicious peer to stall the network by disseminating
seemingly valid block parts in github.com/cometbft/cometbft
More info: https://pkg.go.dev/vuln/GO-2025-3443
Module: github.com/cometbft/cometbft
Found in: github.com/cometbft/[email protected]
Fixed in: github.com/cometbft/[email protected]
Example traces found:
#1: testutil/network/util.go:74:24: network.startInProcess calls service.BaseService.Start, which eventually calls types.Part.ValidateBasic
#2: testutil/network/util.go:74:24: network.startInProcess calls service.BaseService.Start, which eventually calls types.Part.ValidateBasic
#3: client/rpc/block.go:56:36: rpc.QueryBlocks calls local.Local.BlockSearch, which eventually calls types.PartFromProto
#4: client/rpc/block.go:56:36: rpc.QueryBlocks calls local.Local.BlockSearch, which eventually calls types.PartFromProto

Your code is affected by 1 vulnerability from 1 module.
This scan also found 0 vulnerabilities in packages you import and 2
vulnerabilities in modules you require, but your code doesn't appear to call
these vulnerabilities.
Use '-show verbose' for more details.
make: *** [Makefile:155: vulncheck] Error 3

github-actions · 2025-03-20T15:13:35Z

    ⚠️ **govulncheck found vulnerabilities:**


    >mkdir -p /home/runner/work/cosmos-sdk/cosmos-sdk/build/

GOBIN=/home/runner/work/cosmos-sdk/cosmos-sdk/build go install golang.org/x/vuln/cmd/govulncheck@latest
go: downloading golang.org/x/vuln v1.1.4
go: downloading golang.org/x/telemetry v0.0.0-20240522233618-39ace7a40ae7
go: downloading golang.org/x/mod v0.22.0
go: downloading golang.org/x/tools v0.29.0
/home/runner/work/cosmos-sdk/cosmos-sdk/build/govulncheck ./...
=== Symbol Results ===

Vulnerability #1: GO-2025-3443
CometBFT allows a malicious peer to stall the network by disseminating
seemingly valid block parts in github.com/cometbft/cometbft
More info: https://pkg.go.dev/vuln/GO-2025-3443
Module: github.com/cometbft/cometbft
Found in: github.com/cometbft/[email protected]
Fixed in: github.com/cometbft/[email protected]
Example traces found:
#1: testutil/network/util.go:74:24: network.startInProcess calls service.BaseService.Start, which eventually calls types.Part.ValidateBasic
#2: testutil/network/util.go:74:24: network.startInProcess calls service.BaseService.Start, which eventually calls types.Part.ValidateBasic
#3: client/rpc/block.go:56:36: rpc.QueryBlocks calls local.Local.BlockSearch, which eventually calls types.PartFromProto
#4: client/rpc/block.go:56:36: rpc.QueryBlocks calls local.Local.BlockSearch, which eventually calls types.PartFromProto

Your code is affected by 1 vulnerability from 1 module.
This scan also found 0 vulnerabilities in packages you import and 2
vulnerabilities in modules you require, but your code doesn't appear to call
these vulnerabilities.
Use '-show verbose' for more details.
make: *** [Makefile:155: vulncheck] Error 3

github-actions · 2025-03-20T17:04:04Z

    ⚠️ **govulncheck found vulnerabilities:**


    >mkdir -p /home/runner/work/cosmos-sdk/cosmos-sdk/build/

GOBIN=/home/runner/work/cosmos-sdk/cosmos-sdk/build go install golang.org/x/vuln/cmd/govulncheck@latest
go: downloading golang.org/x/vuln v1.1.4
go: downloading golang.org/x/telemetry v0.0.0-20240522233618-39ace7a40ae7
go: downloading golang.org/x/mod v0.22.0
go: downloading golang.org/x/tools v0.29.0
/home/runner/work/cosmos-sdk/cosmos-sdk/build/govulncheck ./...
=== Symbol Results ===

Vulnerability #1: GO-2025-3443
CometBFT allows a malicious peer to stall the network by disseminating
seemingly valid block parts in github.com/cometbft/cometbft
More info: https://pkg.go.dev/vuln/GO-2025-3443
Module: github.com/cometbft/cometbft
Found in: github.com/cometbft/[email protected]
Fixed in: github.com/cometbft/[email protected]
Example traces found:
#1: testutil/network/util.go:74:24: network.startInProcess calls service.BaseService.Start, which eventually calls types.Part.ValidateBasic
#2: testutil/network/util.go:74:24: network.startInProcess calls service.BaseService.Start, which eventually calls types.Part.ValidateBasic
#3: client/rpc/block.go:56:36: rpc.QueryBlocks calls local.Local.BlockSearch, which eventually calls types.PartFromProto
#4: client/rpc/block.go:56:36: rpc.QueryBlocks calls local.Local.BlockSearch, which eventually calls types.PartFromProto

Your code is affected by 1 vulnerability from 1 module.
This scan also found 0 vulnerabilities in packages you import and 2
vulnerabilities in modules you require, but your code doesn't appear to call
these vulnerabilities.
Use '-show verbose' for more details.
make: *** [Makefile:155: vulncheck] Error 3

…abling (#23936)

x/distribution/abci.go

-		if err := k.AllocateTokens(ctx, previousTotalPower, ctx.VoteInfos()); err != nil {
-			return err
-		}
+	if err := k.BeginBlocker(ctx); err != nil {


x/distribution/keeper/abci.go

+	// ref https://github.com/cosmos/cosmos-sdk/issues/3095
+	height := ctx.BlockHeight()
+	if height > 1 {
+		if err := k.AllocateTokens(ctx, previousTotalPower, ctx.VoteInfos()); err != nil {


x/distribution/keeper/abci.go

+
+		// send whole coins from community pool to x/protocolpool if enabled
+		if k.externalCommunityPoolEnabled() {
+			if err := k.sendCommunityPoolToExternalPool(ctx); err != nil {


x/distribution/keeper/abci.go

+
+	// record the proposer for when we pay out on the next block
+	consAddr := sdk.ConsAddress(ctx.BlockHeader().ProposerAddress)
+	return k.SetPreviousProposerConsAddr(ctx, consAddr)


x/protocolpool/keeper/abci.go

+	start := telemetry.Now()
+	defer telemetry.ModuleMeasureSince(types.ModuleName, start, telemetry.MetricKeyBeginBlocker)
+
+	return k.SetToDistribute(ctx)


…le (#24051)

aljo242 added 22 commits March 6, 2025 16:54

add proto

f954802

fixington

da176ba

ok

676f20d

cleanup

cd7d812

cleanup

feddb4f

almost

06b2933

building:

86fb701

working tests

43d2962

minor spec cleanup

258fa30

register

dc5c358

fix

aeff6eb

add test

44c1fed

Merge branch 'release/v0.53.x' into chore/pp

a5a9e28

use latest log

e55c451

add log and update

df0f3cb

readme

1fd59b5

no-manual

003808b

lint fix

2ab838e

add in app di

aa0511c

fix-di

99aa980

lint-fix

6224189

rm-cl

9287af2

github-actions bot added C:Simulations C:x/protocolpool labels Mar 7, 2025

github-advanced-security bot found potential problems Mar 7, 2025

View reviewed changes

aljo242 added 4 commits March 7, 2025 15:35

Merge branch 'release/v0.53.x' into chore/systests

c33f054

Merge branch 'release/v0.53.x' into chore/pp

ce01d67

Merge branch 'release/v0.53.x' into chore/systests

5305ff1

clean up distr test

c80c387

aljo242 added 2 commits March 17, 2025 16:46

Merge branch 'release/v0.53.x' into chore/pp

19a0165

Merge branch 'release/v0.53.x' into chore/pp

5646765

aljo242 added 4 commits March 18, 2025 11:50

Merge branch 'release/v0.53.x' into chore/pp

b3d12f7

lint-fix

c386f89

rm

f08bcbc

Merge branch 'release/v0.53.x' into chore/pp

1cae495

aljo242 added 2 commits March 19, 2025 14:55

update

d8bc8b8

fix

f3b803e

aljo242 added 2 commits March 19, 2025 15:28

Merge branch 'release/v0.53.x' into chore/pp

a5e27f5

update

26a528b

Merge branch 'release/v0.53.x' into chore/pp

9d00bb0

Merge branch 'release/v0.53.x' into chore/pp

bb2efbb

Merge branch 'release/v0.53.x' into chore/pp

cc56aca

feat: add InitOptions to x/distribution keeper for protocol pool en…

76c2fa6

…abling (#23936)

github-actions bot added the C:x/distribution distribution module related label Mar 20, 2025

aljo242 added 2 commits March 20, 2025 14:16

feat: add in distribution to x/protocolpool (#23972)

76e1bf5

Merge branch 'release/v0.53.x' into chore/pp

3fb6b07

github-actions bot added the Type: Build label Mar 20, 2025

feat: add grpc query to x/protocolpool (#24032)

d4cdce8

github-advanced-security bot found potential problems Mar 20, 2025

View reviewed changes

aljo242 added 3 commits March 20, 2025 15:58

fix(protocolpool): community pool query (#24035)

01a5986

fix: set nullable options of x/protocolpool fields to be reasonab…

fc75509

…le (#24051)

Merge branch 'release/v0.53.x' into chore/pp

820aa19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: add `x/protocolpool` #23933

chore: add `x/protocolpool` #23933

aljo242 commented Mar 7, 2025 •

edited

Loading

github-advanced-security bot left a comment

github-actions bot commented Mar 18, 2025 •

edited

Loading

github-actions bot commented Mar 19, 2025

github-actions bot commented Mar 19, 2025

github-actions bot commented Mar 19, 2025

github-actions bot commented Mar 20, 2025

github-actions bot commented Mar 20, 2025

github-actions bot commented Mar 20, 2025

chore: add x/protocolpool #23933

Are you sure you want to change the base?

chore: add x/protocolpool #23933

Conversation

aljo242 commented Mar 7, 2025 • edited Loading

github-advanced-security bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 18, 2025 • edited Loading

github-actions bot commented Mar 19, 2025

github-actions bot commented Mar 19, 2025

github-actions bot commented Mar 19, 2025

github-actions bot commented Mar 20, 2025

github-actions bot commented Mar 20, 2025

github-actions bot commented Mar 20, 2025

chore: add `x/protocolpool` #23933

chore: add `x/protocolpool` #23933

aljo242 commented Mar 7, 2025 •

edited

Loading

github-actions bot commented Mar 18, 2025 •

edited

Loading