Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linter autofixes #23961

Open
wants to merge 2 commits into
base: release/v0.53.x
Choose a base branch
from
Open

linter autofixes #23961

wants to merge 2 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Mar 11, 2025

Description

I'm working on a new module, and the 53 branch isn't linted yet


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@faddat faddat changed the base branch from release/v0.53.x to main March 11, 2025 05:15
@faddat faddat changed the base branch from main to release/v0.53.x March 11, 2025 05:15
Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Good start but there are still linter errors. Would you 👀 : https://github.com/cosmos/cosmos-sdk/actions/runs/13780822496/job/38538639033?pr=23961

@faddat
Copy link
Contributor Author

faddat commented Mar 14, 2025

totally!

So I opened #23962 because it seemed substantially different between main and 53.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants