Skip to content

chore: link validity check #24718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

chore: link validity check #24718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bb92caf
link check
aljo242 May 6, 2025
b990faa
ignore
aljo242 May 6, 2025
44b7d54
cleanup
aljo242 May 6, 2025
14e7806
remove contributing
aljo242 May 6, 2025
9efced9
remove-coding-guidelines
aljo242 May 6, 2025
14b7e05
utd
aljo242 May 6, 2025
e4e7ee6
attempt
aljo242 May 8, 2025
c4f68e7
Merge branch 'main' into chore/link-validity
aljo242 May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ are the most critical to review. -->
## Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues. Your PR will not be merged unless you satisfy
please add links to any relevant followup issues. Your PR will not be merged unless you satisfy
all of these items.*

I have...
Expand All @@ -28,10 +28,9 @@ I have...
* `chore`: Other changes that don't modify src or test files
* `revert`: Reverts a previous commit -->
* [ ] confirmed `!` in the type prefix if API or client breaking change
* [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
* [ ] provided a link to the relevant issue or specification
* [ ] reviewed "Files changed" and left comments if necessary
* [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
* [ ] included the necessary unit and integration tests
* [ ] added a changelog entry to `CHANGELOG.md`
* [ ] updated the relevant documentation or specification, including comments for [documenting Go code](https://blog.golang.org/godoc)
* [ ] confirmed all CI checks have passed
Expand Down
7 changes: 7 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,14 @@ vagrant
.dir-locals.el
.vscode

# python
.venv
bin
lib
pyvenv.cfg
Comment on lines +55 to +59
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Avoid overly broad ignore patterns for common directories.
Ignoring bin and lib at the repo root can inadvertently hide legitimate files or folders named bin or lib. Since .venv already covers these subdirectories, remove the generic entries or scope them to the virtual environment.

Consider applying this diff:

@@ .gitignore
-# python
-.venv
-bin
-lib
-pyvenv.cfg
+# python
+.venv/
+# pyvenv.cfg (virtual environment metadata)
+pyvenv.cfg
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# python
.venv
bin
lib
pyvenv.cfg
# python
.venv/
# pyvenv.cfg (virtual environment metadata)
pyvenv.cfg
🤖 Prompt for AI Agents (early access) 
In the .gitignore file around lines 55 to 59, the entries for ignoring 'bin' and
'lib' are too broad and may unintentionally exclude important files or
directories named 'bin' or 'lib' outside the virtual environment. Remove these
generic 'bin' and 'lib' ignore patterns or modify them to specifically target
the virtual environment subdirectories, since '.venv' already covers these
paths. This will prevent accidentally ignoring unrelated files.


#docs scripting
docs_links_status.md

# Depinject & Graphviz
dependency-graph.png
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ Ref: https://keepachangelog.com/en/1.0.0/

### Bug Fixes

* (x/auth/vesting) [GHSA-4j93-fm92-rp4m](#bug-fixes) Add `BlockedAddr` check in `CreatePeriodicVestingAccount`.
* (x/auth/vesting) [GHSA-4j93-fm92-rp4m] Add `BlockedAddr` check in `CreatePeriodicVestingAccount`.
* (baseapp) [#19338](https://github.com/cosmos/cosmos-sdk/pull/19338) Set HeaderInfo in context when calling `setState`.
* (baseapp): [#19200](https://github.com/cosmos/cosmos-sdk/pull/19200) Ensure that sdk side ve math matches cometbft.
* [#19106](https://github.com/cosmos/cosmos-sdk/pull/19106) Allow empty public keys when setting signatures. Public keys aren't needed for every transaction.
Expand Down
152 changes: 0 additions & 152 deletions CODING_GUIDELINES.md
View file
Open in desktop

This file was deleted.

Loading
Loading