feat: verbose logging during upgrades (backport #24720) #24747
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #22522
This PR addresses the need for more verbose logging during upgrades by
VerboseModeLogger
extension interface andVerboseLevel
option to log packagex/upgrade
verbose_log_level
flag to the server for configuring the verbose log level (defaults todebug
even though the issue statesinfo
because the defaultlog_level
is alreadyinfo
)There is an e2e upgrade test that verifies that this works. In addition, I have manually verified (by modifying
--log_level
and--verbose_log_level
in these tests) that:--verbose_log_level
can be set from the CLI--log_level
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues. Your PR will not be merged unless you satisfy
all of these items.
I have...
included the correct type prefix in the PR title, you can find examples of the prefixes below:
confirmed
!
in the type prefix if API or client breaking changetargeted the correct branch (see PR Targeting)
provided a link to the relevant issue or specification
reviewed "Files changed" and left comments if necessary
included the necessary unit and integration tests
added a changelog entry to
CHANGELOG.md
updated the relevant documentation or specification, including comments for documenting Go code
confirmed all CI checks have passed
Summary by CodeRabbit
New Features
Improvements
Bug Fixes
Documentation
Tests
This is an automatic backport of pull request #24720 done by [Mergify](https://mergify.com).