Skip to content

Conversation

@davidjsonn
Copy link
Contributor

@davidjsonn davidjsonn commented Aug 2, 2025

Description

becomes - become
Cosmosvisor - Cosmovisor
is >1 sdk.Msgs. - deleted redundant
could all this - could call this
environment and the this - deleted redundant
be closed by the caller. - add be
the has HasPreBlocker - deleted redundant
though - through
short comings - shortcomings
malleablity - malleability

Summary by CodeRabbit

  • Documentation
    • Corrected various typographical and grammatical errors across multiple architecture decision records to improve clarity and accuracy. No changes were made to logic, functionality, or recommendations.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 2, 2025

📝 Walkthrough

Walkthrough

A series of minor grammatical and typographical corrections were made across multiple ADR documentation files. These changes address spelling errors, grammar mistakes, and clarity issues, but do not alter any functional, logical, or technical content in the documents.

Changes

Cohort / File(s) Change Summary
Grammar and Typo Fixes in ADRs
docs/architecture/adr-046-module-params.md, docs/architecture/adr-047-extend-upgrade-plan.md, docs/architecture/adr-050-sign-mode-textual.md, docs/architecture/adr-054-semver-compatible-modules.md, docs/architecture/adr-058-auto-generated-cli.md, docs/architecture/adr-059-test-scopes.md, docs/architecture/adr-060-abci-1.0.md, docs/architecture/adr-063-core-module-api.md, docs/architecture/adr-065-store-v2.md, docs/architecture/adr-076-tx-malleability.md
Corrected various grammatical, typographical, and spelling errors throughout the documentation. No changes to logic, code, or technical content.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (5)
docs/architecture/adr-058-auto-generated-cli.md (1)

83-85: Clarify pluralization in the fixed sentence

Nice catch on “lie” vs “line.”
While you are touching this sentence, consider removing the extra “s” so it reads “customization options” (singular noun, plural object).

-as to whether these customizations options should lie in:
+as to whether these customization options should lie in:
docs/architecture/adr-060-abci-1.0.md (1)

85-88: Replace hard tab with spaces for markdown-lint compliance

markdownlint flags hard tabs (MD010). Swapping the single tab for two spaces avoids the warning without affecting the Go snippet’s readability.

-	// be closed by the caller.
+  // be closed by the caller.
docs/architecture/adr-063-core-module-api.md (2)

283-286: Use singular form for interface name

HasPreBlocker is a single interface, not multiple.

-Modules that have functionality that runs before BeginBlock and should implement the `HasPreBlocker` interfaces:
+Modules that have functionality that runs before BeginBlock should implement the `HasPreBlocker` interface:

296-299: Remove stray word “has”

Minor grammar touch-up keeps the doc professional and unambiguous.

-(end blockers) should implement the has `HasBeginBlocker` and/or `HasEndBlocker` interfaces:
+(end blockers) should implement the `HasBeginBlocker` and/or `HasEndBlocker` interfaces:
docs/architecture/adr-050-sign-mode-textual.md (1)

228-231: Tweak pluralisation helper comment

The example is still a bit clumsy and duplicates spaces. A small edit improves readability.

-This transaction has <int> message:   // Optional 's' for "message" if there's  >1 sdk.Msgs.
+This transaction has <int> message(s):   // Optional 's' for "message' if there are >1 sdk.Msgs.
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 944a3bc and 5572a05.

📒 Files selected for processing (10)
  • docs/architecture/adr-046-module-params.md (1 hunks)
  • docs/architecture/adr-047-extend-upgrade-plan.md (2 hunks)
  • docs/architecture/adr-050-sign-mode-textual.md (1 hunks)
  • docs/architecture/adr-054-semver-compatible-modules.md (1 hunks)
  • docs/architecture/adr-058-auto-generated-cli.md (1 hunks)
  • docs/architecture/adr-059-test-scopes.md (1 hunks)
  • docs/architecture/adr-060-abci-1.0.md (1 hunks)
  • docs/architecture/adr-063-core-module-api.md (1 hunks)
  • docs/architecture/adr-065-store-v2.md (2 hunks)
  • docs/architecture/adr-076-tx-malleability.md (1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
docs/architecture/adr-060-abci-1.0.md

87-87: Hard tabs
Column: 1

(MD010, no-hard-tabs)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Summary
🔇 Additional comments (6)
docs/architecture/adr-059-test-scopes.md (1)

154-157: Typo fixed – looks good

The removal of the duplicate article makes the sentence flow correctly.
No further issues spotted.

docs/architecture/adr-076-tx-malleability.md (1)

129-133: Corrected spelling – good to merge

“Malleability” is now spelled correctly; content remains unchanged.

docs/architecture/adr-046-module-params.md (1)

163-166: Grammar fix accepted

Changing “becomes” → “become” aligns subject–verb agreement.
No other concerns.

docs/architecture/adr-054-semver-compatible-modules.md (1)

474-476: Typo fix approved

The sentence now reads correctly (“could call this”).

docs/architecture/adr-065-store-v2.md (1)

38-39: Clarity improvement looks good

Replacing “through” and fixing “shortcomings” reads better; no further action required.

docs/architecture/adr-047-extend-upgrade-plan.md (1)

60-63: Correct branding spelling approved

Changing “Cosmosvisor” ➜ “Cosmovisor” keeps naming consistent.

@aljo242 aljo242 merged commit 3e0433e into cosmos:main Aug 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants