-
Notifications
You must be signed in to change notification settings - Fork 4.1k
chore: polishing docs and comments: typo fixes for clarity #25081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThis set of changes consists entirely of minor documentation and comment corrections across multiple files. Adjustments include fixing typographical errors, formatting inconsistencies, and updating links in documentation and changelogs. No changes were made to code logic, control flow, or the behavior of any exported entities. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
runtime/app.go (1)
94-96: Grammar tweak for clarityMinor wording nit: the sentence still reads a bit awkwardly.
-// which is necessary for modules that not registered using the app config. +// which is necessary for modules that are not registered using the app config.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting
📒 Files selected for processing (11)
docs/spec/store/README.md(1 hunks)errors/doc.go(1 hunks)errors/errors.go(1 hunks)internal/testutil/cmd_test.go(1 hunks)math/CHANGELOG.md(1 hunks)runtime/app.go(1 hunks)runtime/events.go(1 hunks)server/util.go(1 hunks)server/util_test.go(1 hunks)store/cachekv/store_bench_test.go(1 hunks)store/rootmulti/store.go(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Summary
🔇 Additional comments (10)
store/cachekv/store_bench_test.go (1)
23-25: LGTM – typo removal onlyThe stray bracket was removed; comment now reads cleanly.
errors/doc.go (1)
9-11: LGTM – corrected prepositionTypo fix improves the package doc; nothing further.
server/util_test.go (1)
404-405: LGTM – typo fix“non-existent” is now spelled correctly.
server/util.go (1)
72-75: LGTM – env-var example correctedExample variable name now matches the flag; good catch.
errors/errors.go (1)
188-190: Correct article usage in comment – looks good
Switching to “an error” improves clarity without affecting behavior.runtime/events.go (1)
35-35: Whitespace cleanup acknowledged
Trailing-space removal keeps comments tidy.store/rootmulti/store.go (1)
631-633: Typo fixed in comment
“doesn't” reads correctly; no further action needed.docs/spec/store/README.md (1)
103-107: Grammar correction appreciated
Changing “a irrecoverable” to “an irrecoverable” enhances readability.math/CHANGELOG.md (1)
143-144: Updated link targets the correct PR
The reference now points to pull request #15506 instead of the issue—accurate and helpful.internal/testutil/cmd_test.go (1)
89-89: LGTM! Grammar improvement enhances code clarity.The correction from "built pflag.SliceValue" to "built-in pflag.SliceValue" properly hyphenates the compound adjective and improves the readability of the comment.
Description
a irrecoverable - an irrecoverable
needed my many - needed by many
a error - an error
check built - check built-in
wiich - which
an typed - a typed
STING_FAVORITE_COLOR - STRING_FAVORITE_COLOR
non-existen - non-existent
sequentially after.] -- deleted extra ]
donesn't - doesn't
fix link in
math/CHANGELOG.mdhttps://github.com/cosmos/cosmos-sdk/issues/ 16605 - old
https://github.com/cosmos/cosmos-sdk/pull/ 15506 - new
The link was correctly fixed (please check if you have any doubts)
Summary by CodeRabbit