-
Notifications
You must be signed in to change notification settings - Fork 4.1k
docs(consensus): enhance README with comprehensive module documentation #25300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughDocumentation-only update: expanded x/consensus README from a single-line description to a detailed, governance-focused guide covering parameter categories, usage (MsgUpdateParams), queries, architecture components, and security constraints. No code or API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
🧹 Nitpick comments (3)
x/consensus/README.md (3)
36-38: Add ABCI param example (VoteExtensionsEnableHeight).Since ABCI params are documented above, include them in the usage snippet for completeness.
Validator: &types.ValidatorParams{ PubKeyTypes: []string{"ed25519"}, }, + Abci: &types.ABCIParams{ + VoteExtensionsEnableHeight: 123456, + },Also applies to: 45-61
28-33: Document cross-constraint: Evidence.MaxBytes must not exceed Block.MaxBytes.Prevents invalid configurations.
- `MaxBytes`: Maximum evidence size in bytes + +> Note: Evidence.MaxBytes must be ≤ Block.MaxBytes.
79-82: Grammar nit.- - Updates are subject to governance approval process + - Updates are subject to the governance approval process.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting
📒 Files selected for processing (1)
x/consensus/README.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
x/consensus/README.md
[grammar] ~25-~25: There might be a mistake here.
Context: ... MaxBytes: Maximum block size in bytes - MaxGas: Maximum gas per block ### Evidence Pa...
(QB_NEW_EN)
[grammar] ~29-~29: There might be a mistake here.
Context: ...ocks: Maximum age of evidence in blocks - MaxAgeDuration: Maximum age of evidence in time - Max...
(QB_NEW_EN)
[grammar] ~30-~30: There might be a mistake here.
Context: ...ration: Maximum age of evidence in time - MaxBytes`: Maximum evidence size in bytes ### Va...
(QB_NEW_EN)
[grammar] ~73-~73: There might be a mistake here.
Context: ...Manages parameter storage and validation - Types: Defines message types and param...
(QB_NEW_EN)
[grammar] ~74-~74: There might be a mistake here.
Context: ...s message types and parameter structures - Module: Integrates with the Cosmos SDK...
(QB_NEW_EN)
[grammar] ~81-~81: There might be a mistake here.
Context: ...efore application - Updates are subject to governance approval process
(QB_NEW_EN)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Summary
|
@technicallyty to review when he returns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we should apply most of the coderrabbit's suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more thing then should be good to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome thank you
Improve x/consensus README.md with:
This makes the module more discoverable and easier to understand
for developers working with consensus parameters.
Summary by CodeRabbit