Skip to content

Conversation

@ammar-elsabe
Copy link
Contributor

Description

Closes: #25420

  • Changed the keeper type in x/epochs ModuleOutputs to be a pointer to the keeper stored in the AppModule
    • EpochsKeeper's type in simapp/app_di.go was updated to match
  • Added a test to verify depinject finds and invokes setting hooks
  • Documented how to wire x/epochs in the README

@ammar-elsabe ammar-elsabe force-pushed the main branch 6 times, most recently from 735c574 to f32e9cb Compare October 11, 2025 09:02
@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.30%. Comparing base (23f1ff1) to head (d0873d0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main   #25425    +/-   ##
========================================
  Coverage   70.30%   70.30%            
========================================
  Files         828      822     -6     
  Lines       53818    53627   -191     
========================================
- Hits        37839    37705   -134     
+ Misses      15979    15922    -57     
Files with missing lines Coverage Δ
simapp/app_di.go 78.89% <ø> (ø)
x/epochs/depinject.go 86.36% <100.00%> (-4.55%) ⬇️
x/epochs/module.go 63.26% <100.00%> (ø)

... and 10 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ammar-elsabe ammar-elsabe force-pushed the main branch 2 times, most recently from 8dc36f3 to ecfea47 Compare October 21, 2025 06:13
@ammar-elsabe
Copy link
Contributor Author

@aljo242 fixed the build

@aljo242 aljo242 enabled auto-merge October 30, 2025 15:29
@aljo242 aljo242 added this pull request to the merge queue Oct 30, 2025
Merged via the queue into cosmos:main with commit f665371 Oct 30, 2025
65 of 66 checks passed
warpbuild-benchmark-bot bot added a commit to WarpBuilds/cosmos-sdk that referenced this pull request Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

InvokeSetHooks in x/epochs is called with a nil keeper

2 participants