Skip to content

Conversation

@aljo242
Copy link
Contributor

@aljo242 aljo242 commented Oct 17, 2025

Note: regenerating proto because i added a proto definition of the BLS key.

This meant that some typos in .proto files ended up in .pulsar and .pb.go files

@github-actions github-actions bot added C:x/staking C:CLI C:Simulations C:Store C:x/auth C:Cosmovisor Issues and PR related to Cosmovisor C:Confix Issues and PR related to Confix labels Oct 17, 2025
@aljo242 aljo242 changed the title chore: bump comet to use beta tag feat: enable BLS and bump comet to beta tag Oct 17, 2025
@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.83%. Comparing base (d081460) to head (3c24aac).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crypto/codec/cmt.go 0.00% 10 Missing ⚠️
crypto/codec/amino.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #25471      +/-   ##
==========================================
- Coverage   52.88%   52.83%   -0.05%     
==========================================
  Files         797      798       +1     
  Lines       64903    64953      +50     
==========================================
- Hits        34322    34317       -5     
- Misses      30581    30636      +55     
Files with missing lines Coverage Δ
baseapp/internal/protocompat/protocompat.go 0.00% <ø> (ø)
crypto/keys/bls12_381/key.go 0.00% <ø> (ø)
crypto/keys/multisig/codec.go 100.00% <100.00%> (ø)
server/api/server.go 61.71% <ø> (ø)
server/grpc/gogoreflection/serverreflection.go 1.92% <ø> (ø)
x/auth/tx/service.go 0.00% <ø> (ø)
crypto/codec/amino.go 0.00% <0.00%> (ø)
crypto/codec/cmt.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

protoiface "google.golang.org/protobuf/runtime/protoiface"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
io "io"
reflect "reflect"

Check notice

Code scanning / CodeQL

Sensitive package import Note

Certain system packages contain functions which may be a possible source of non-determinism
@aljo242 aljo242 merged commit 3077677 into main Oct 17, 2025
43 of 44 checks passed
@aljo242 aljo242 deleted the chore/bump-comet branch October 17, 2025 18:48
warpbuild-benchmark-bot bot added a commit to WarpBuilds/cosmos-sdk that referenced this pull request Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C:CLI C:Confix Issues and PR related to Confix C:Cosmovisor Issues and PR related to Cosmovisor C:Simulations C:Store C:x/auth C:x/staking

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants