fix: isolate CheckTx and simulation state from DeliverTx commits #25529
+61
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @aljo242, can you check this approach? I’ve tested the update using these test cases, and it appears to be working well. However, it’s difficult to merge the tests into the main branch since they depend on some changes in the ante module. |
|
@beer-1 could you please re-open these with signed commits? |
…oading the last committed snapshot and keeping the simulation context in sync
beer-1
force-pushed
the
fix/state-pollution
branch
from
b6870ac to
8f8e43a
Compare
|
@aljo242 changed to use signed commit |
|
I fixed the race data write by changing RWMutex to Mutex |
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…osmos#25535) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alex | Cosmos Labs <[email protected]>
beer-1
force-pushed
the
fix/state-pollution
branch
from
398b597 to
5f2df19
Compare
github-actions
bot
added
C:x/staking
C:CLI
C:x/gov
C:Keys
github-actions
bot
added
C:x/tx
C:x/protocolpool
C:x/epochs
and removed
C:x/staking
C:CLI
C:x/gov
C:Keys
|
@aljo242 introduced a mutex for cms(CacheMultiStore).stores to prevent data races during lazy loading. This issue was mainly observed in concurrent genesis export tests. and succeed to pass tests locally with update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Isolate CheckTx and simulation state from DeliverTx commits by loading the last committed snapshot and keeping the simulation context in sync
Closes: #20685 #23891