Skip to content

Conversation

@Doryu001
Copy link

@Doryu001 Doryu001 commented Nov 3, 2025

Drop the preallocation of kvAs/kvBs slices that were immediately overwritten by getKVPairs retain existing concurrency logic while trimming an unnecessary heap allocation per iterator

@aljo242 aljo242 changed the title Chore: remove redundant slice allocations in DiffKVStores chore: remove redundant slice allocations in DiffKVStores Nov 3, 2025
@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.27%. Comparing base (84e841a) to head (03abbbf).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #25538      +/-   ##
==========================================
+ Coverage   69.99%   70.27%   +0.28%     
==========================================
  Files         827      822       -5     
  Lines       54070    53627     -443     
==========================================
- Hits        37844    37689     -155     
+ Misses      16226    15938     -288     
Files with missing lines Coverage Δ
testutil/sims/simulation_helpers.go 56.19% <100.00%> (ø)

... and 8 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aljo242
Copy link
Contributor

aljo242 commented Nov 3, 2025

low impace

@aljo242 aljo242 closed this Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants