Skip to content

Conversation

@nikugogoi
Copy link

Description

Closes: #25665

The collFilteredPaginateNoKey method is updated to handle pagination offset when predicateFunc is set. Also added test case for filtering a collection with pagination offset.

@nikugogoi nikugogoi changed the title Fix/paginate filter offset fix: collection pagination with predicate function and offset Dec 17, 2025
@nikugogoi nikugogoi force-pushed the fix/paginate-filter-offset branch 2 times, most recently from e912d7a to fd6a54e Compare December 17, 2025 13:56
@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.23%. Comparing base (5aead0f) to head (fd6a54e).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #25718      +/-   ##
==========================================
+ Coverage   68.28%   70.23%   +1.95%     
==========================================
  Files         870      835      -35     
  Lines       56500    54412    -2088     
==========================================
- Hits        38580    38216     -364     
+ Misses      17920    16196    -1724     
Files with missing lines Coverage Δ
types/query/collections_pagination.go 89.57% <100.00%> (+2.98%) ⬆️

... and 38 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nikugogoi nikugogoi force-pushed the fix/paginate-filter-offset branch from fd6a54e to 7a855ce Compare December 18, 2025 06:08
@nikugogoi nikugogoi force-pushed the fix/paginate-filter-offset branch from 7a855ce to 952b034 Compare December 18, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect pagination with predicateFunc in CollectionFilteredPaginate

1 participant