Skip to content

Conversation

@heksan-ui
Copy link
Contributor

Description

  • Use "zero value" instead of "nil" for generic type comments (V can be any type, not just pointer)
  • Fix inaccurate return value description for estimate case in Read()
  • Fix typo: "closing" → "closest" in mvdata.go
  • Add missing SUSPENDED status to txnStatus comment
  • Replace fragile line number reference with explicit entry.Lock() in scheduler.go
  • Minor punctuation fixes

@heksan-ui heksan-ui changed the title blockstm: fix comments and documentation docs(blockstm): fix comments and documentation Dec 22, 2025
Copy link
Contributor

@aljo242 aljo242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requesting small change

@heksan-ui
Copy link
Contributor Author

requesting small change

ready for review

@heksan-ui heksan-ui requested a review from aljo242 January 6, 2026 17:16
@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.50%. Comparing base (fd82917) to head (1e242e8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #25721      +/-   ##
==========================================
+ Coverage   70.26%   70.50%   +0.24%     
==========================================
  Files         835      835              
  Lines       54361    54361              
==========================================
+ Hits        38196    38328     +132     
+ Misses      16165    16033     -132     
Files with missing lines Coverage Δ
blockstm/memdb.go 97.77% <ø> (ø)
blockstm/mvdata.go 97.00% <ø> (ø)
blockstm/mvview.go 86.40% <ø> (ø)
blockstm/scheduler.go 94.56% <ø> (ø)

... and 4 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aljo242 aljo242 enabled auto-merge January 6, 2026 18:09
@aljo242 aljo242 added this pull request to the merge queue Jan 6, 2026
Merged via the queue into cosmos:main with commit 5f9099f Jan 6, 2026
41 checks passed
warpbuild-benchmark-bot bot added a commit to WarpBuilds/cosmos-sdk that referenced this pull request Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants