Skip to content

Conversation

@Fibonacci747
Copy link

@Fibonacci747 Fibonacci747 commented Dec 21, 2025

Description

Reopen #25675
Time‑based FutureOperations were never actually used: they were created but never stored in the shared queue or removed from it, so they never executed.
queueOperations and runQueuedTimeOperations took the time queue slice by value and modified only a local copy. We changed both functions to take a *[]FutureOperation and updated all call sites to pass &timeOperationQueue, then updated the code to work through the pointer. Now time‑scheduled operations are correctly enqueued, executed when their BlockTime is reached, and removed from the global queue.

@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

❌ Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.35%. Comparing base (fd82917) to head (237ccc6).

Files with missing lines Patch % Lines
x/simulation/simulate.go 50.00% 3 Missing ⚠️
x/simulation/operation.go 87.50% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #25722      +/-   ##
==========================================
+ Coverage   70.26%   70.35%   +0.08%     
==========================================
  Files         835      835              
  Lines       54361    54363       +2     
==========================================
+ Hits        38196    38246      +50     
+ Misses      16165    16117      -48     
Files with missing lines Coverage Δ
x/simulation/operation.go 34.92% <87.50%> (+34.92%) ⬆️
x/simulation/simulate.go 5.80% <50.00%> (+5.80%) ⬆️

... and 3 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aljo242
Copy link
Contributor

aljo242 commented Jan 6, 2026

could we just do a copy operation instead of this - this seems quite brittle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants