fix(x/staking): validate bond_denom exists before updating params #25736
+35
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes cosmos#25724 Add validation in MsgUpdateParams handler to check that bond_denom has non-zero supply before allowing governance to update it. This prevents governance from setting bond_denom to a non-existent denom which would place the chain in an unsafe state. The fix queries the bank module's GetSupply to verify the denom exists on-chain. If supply is zero, the handler returns ErrInvalidDenom. Changes: - Add supply check in UpdateParams handler using bankKeeper.GetSupply - Return ErrInvalidDenom if bond_denom has zero supply - Add test case for non-existent denom validation - Add ErrInvalidDenom error constant (error code 46) - Fix autocli help message golden file (TimeoutTimestamp -> TimeoutDuration)
Contributor
|
closing as we require signed commits - please reopen with signed commits! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #25724
Adds validation to prevent governance from setting
bond_denomto a non-existent denom viaMsgUpdateParams.Problem
The staking module currently allows governance to update
bond_denomwithout validating that the denom exists on-chain. This creates a governance footgun where:bond_denomto a non-existent denom places the chain in an unsafe stateSolution
Add validation in the
UpdateParamshandler to check that the newbond_denomhas non-zero supply in the bank module before allowing the update.Changes
UpdateParamshandler usingbankKeeper.GetSupplyErrInvalidDenomifbond_denomhas zero supplyErrInvalidDenomerror constant (code 46)Testing