Skip to content

fix(rpc): emit canonical block hash in newHeads subscription #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
puneet2019 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(rpc): emit canonical block hash in newHeads subscription #1214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81c4558
fix(rpc): emit canonical block hash in newHeads subscription
puneet2019 Jul 2, 2026
f7760bb
Merge branch 'main' into fix/newheads-canonical-hash
puneet2019 Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@

### BUG FIXES

- [\#1214](https://github.com/cosmos/evm/pull/1214) Emit the canonical CometBFT block hash in the `newHeads` subscription so it matches `eth_getBlockByNumber` (completes [\#725](https://github.com/cosmos/evm/pull/725)).
- [\#1047](https://github.com/cosmos/evm/pull/1047) Resolve EthTxIndex -1 sentinel before uint cast in ReceiptsFromCometBlock, preventing transactionIndex overflow to MaxUint64.
- [\#965](https://github.com/cosmos/evm/pull/965) Fix gas double charging on EVM calls in IBCOnTimeoutPacketCallback.
- [\#869](https://github.com/cosmos/evm/pull/869) Fix erc20 IBC callbacks to check for native token transfer before parsing recipient.
Expand Down
3 changes: 2 additions & 1 deletion rpc/websockets.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import (

rpcfilters "github.com/cosmos/evm/rpc/namespaces/ethereum/eth/filters"
"github.com/cosmos/evm/rpc/stream"
rpctypes "github.com/cosmos/evm/rpc/types"
"github.com/cosmos/evm/server/config"

"cosmossdk.io/log/v2"
Expand Down Expand Up @@ -463,7 +464,7 @@ func (api *pubSubAPI) subscribeNewHeads(wsConn *wsConn, subID rpc.ID) (context.C
Method: "eth_subscription",
Params: &SubscriptionResult{
Subscription: subID,
Result: header.EthHeader,
Result: rpctypes.RPCMarshalHeader(header.EthHeader, header.Hash.Bytes()),
},
}

Expand Down
Loading