-
Notifications
You must be signed in to change notification settings - Fork 18
deps: Remove SDK Fork #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
x/evm limits the number of precompiles call made from a contract to the arbitrary number 7: Lines 12 to 15 in a48a796
I think the comment is related to this (I might be wrong though). Does this change make it any better, or does it not impact this at all? I don't know if changing from |
It seems like the number of precompile calls within a given txn is tracked at the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me - I read the test that breaks if you don't use Copy() or CacheMultiStore(), and it seems like either method would fix it. I don't think we need to be making a deep copy of the store, using CacheMultiStore on a CacheMultiStore-generated object looks like it works. Should be more efficient too :)
// Would probably want more tests on this eventually though.
One key difference I've confirmed between CacheMultiStore()
Copy()
This distinction is subtle but has significant implications.
Unless shared cache behavior is explicitly intended and carefully controlled, this change can introduce non-obvious side effects. I’d recommend reviewing whether this change is safe across all usage paths—especially in areas where Reference test cases:
|
Description
Removes the fork of the cosmos sdk--only dependency here is the
Copy
function.Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
main
branchReviewers Checklist
All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.
I have...
Unreleased
section inCHANGELOG.md