Skip to content

Conversation

@mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Nov 11, 2025

Description

depends on cosmos/cosmos-sdk#25565, for test info


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.29%. Comparing base (b07425e) to head (37f868a).

Files with missing lines Patch % Lines
server/config/config.go 50.00% 1 Missing and 1 partial ⚠️
server/start.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #815      +/-   ##
==========================================
+ Coverage   65.22%   65.29%   +0.06%     
==========================================
  Files         317      317              
  Lines       21624    21594      -30     
==========================================
- Hits        14105    14100       -5     
+ Misses       6357     6330      -27     
- Partials     1162     1164       +2     
Files with missing lines Coverage Δ
server/start.go 0.00% <0.00%> (ø)
server/config/config.go 46.80% <50.00%> (+0.09%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mmsqe mmsqe changed the title feat: support for multi gRPC query clients serve with old binary feat: support proxy with grpc-only mode Nov 11, 2025
@mmsqe mmsqe marked this pull request as ready for review November 13, 2025 04:08
@mmsqe mmsqe marked this pull request as draft November 17, 2025 15:17
@mmsqe mmsqe marked this pull request as ready for review November 19, 2025 16:08
}

// startGrpcServer starts a gRPC server based on the provided configuration.
func startGrpcServer(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it ok to remove all of this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we can replace with sdk StartGrpcServer?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming here that this was a duplicate function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants