Skip to content

Conversation

@mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Nov 26, 2025

Description

  • repalce legacytx.StdSignBytes with the aminojson sign mode handler in eip712
  • add ParseChainID allow use the configured EVM chain ID
  • pytest -vv -s test_eip712.py::test_without_extension --chain-config evmd
  • pytest -vv -s test_eip712.py::test_native_tx --chain-config evmd, if enble extension in antehandler

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

❌ Patch coverage is 59.59596% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.51%. Comparing base (8f242bf) to head (95813af).

Files with missing lines Patch % Lines
ante/cosmos/eip712.go 0.00% 28 Missing ⚠️
ethereum/eip712/encoding.go 79.31% 3 Missing and 3 partials ⚠️
ethereum/eip712/encoding_legacy.go 79.31% 3 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #860      +/-   ##
==========================================
+ Coverage   64.06%   65.51%   +1.45%     
==========================================
  Files         318      318              
  Lines       22289    22279      -10     
==========================================
+ Hits        14279    14597     +318     
+ Misses       6572     6513      -59     
+ Partials     1438     1169     -269     
Files with missing lines Coverage Δ
ethereum/eip712/types.go 92.74% <100.00%> (+0.52%) ⬆️
ethereum/eip712/encoding.go 76.37% <79.31%> (-1.81%) ⬇️
ethereum/eip712/encoding_legacy.go 74.02% <79.31%> (-1.16%) ⬇️
ante/cosmos/eip712.go 2.75% <0.00%> (-0.35%) ⬇️

... and 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aljo242
Copy link
Contributor

aljo242 commented Dec 2, 2025

@mmsqe could you share more about why this change is needed?

@mmsqe
Copy link
Collaborator Author

mmsqe commented Dec 2, 2025

@mmsqe could you share more about why this change is needed?

I try to avoid legacytx.StdSignBytes is deprecated: Please use x/tx/signing/aminojson instead when update sdk, but just notice we don't handle /cosmos.evm.eip712.v1.ExtensionOptionsWeb3Tx in anteHandler, not sure the status of eip712.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants