-
Notifications
You must be signed in to change notification settings - Fork 142
test: block-stm app #879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
test: block-stm app #879
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #879 +/- ##
==========================================
- Coverage 64.06% 62.84% -1.22%
==========================================
Files 318 318
Lines 22289 22217 -72
==========================================
- Hits 14279 13963 -316
- Misses 6572 7042 +470
+ Partials 1438 1212 -226
🚀 New features to boost your workflow:
|
| test-unit-cover: TEST_PACKAGES=$(PACKAGES_UNIT) | ||
| test-unit-cover: run-tests | ||
| @echo "🔍 Running evm (root) coverage..." | ||
| @go test -race -tags=test $(COMMON_COVER_ARGS) -coverpkg=$(COVERPKG_ALL) -coverprofile=coverage.txt ./... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add this back?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aljo242
I branched this PR off of PR #825, and the removal of the -race flag was a change introduced in PR #825.
We may need confirmation from @vladjdk, the author of PR #825.
@vladjdk
Was this change intentional?
As far as I know, enabling the -race option allows data race detection, but it also increases the build size as well as execution time and memory usage.
Description
Closes: #XXXX
Inject block-stm-enabled app into existing tests
This PR should be merged after #845 is merged
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranch