feat(mempool): remove redundant locks #915
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes mutex calls from high-level mempool as underlying mempools are already thread-safe.
Local tests showed that
insertEVMtook up to ~10ms for the lock, and SelectBy up to ~80ms, which is a lot for consensus progression.Note:
txpool.Add()is still slow because it also has a lock inside geth's part of the codebase and also perform some operations under this lock. Local bench showed that it might take up to ~10ms for this operation,evm/mempool/txpool/legacypool/legacypool.go
Line 1095 in 48bde58
Overall,
abci.InsertTx()takes ~30msCloses STACK-2019