chore(deps): ibc-go to v10.1.1, wasmd 0.55.1 #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ibc-hooks
Contributor
Author
|
closes #257 |
gjermundgaraba
requested changes
Aug 24, 2025
Contributor
gjermundgaraba
left a comment
gjermundgaraba
left a comment
There was a problem hiding this comment.
Thank you! This mostly looks good, but needs a bit of cleanup to bring over the finish line
| // 2. 'auth' | ||
| // 3. 'ibc channel' | ||
| // 4. 'ibc port' | ||
| app.IBCKeeper = ibckeeper.NewKeeper( |
Contributor
There was a problem hiding this comment.
The comment here was wrong, this is not the fee keeper
Contributor
Author
There was a problem hiding this comment.
weird, ibckeeper already existed:
https://github.com/cosmos/ibc-apps/pull/272/files?diff=unified#diff-c7aeadef5480ea593dd152867ab52c7f60e2df19c2ada3766951cd5f3d54bc1aR512
already exists before
Co-authored-by: Gjermund Garaba <[email protected]>
puneet2019
commented
Aug 25, 2025
Co-authored-by: Gjermund Garaba <[email protected]>
gjermundgaraba
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.