Skip to content

feat: Packet forward middleware #8285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 76 commits into from
May 15, 2025
Merged

feat: Packet forward middleware #8285

merged 76 commits into from
May 15, 2025
+4,335 −87

Conversation

DeshErBojhaa
Copy link
Contributor

@DeshErBojhaa DeshErBojhaa commented Apr 9, 2025 •
edited
Loading

Description

This PR ports packet-forward-middleware from ibc-apps repo.

closes: #8269

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@DeshErBojhaa
chore: update minor dependencies
58e0268
@DeshErBojhaa
feat: move packet_forward_middleware from ibc-app to ibc-go repo.
863799f 
First commit. Porting minimum necessary files for a non broken codebase. Gradual update on this branch eventually will port all code from ibc-app -> ibc-go.
@DeshErBojhaa
fix: run go mod tidy
2f0b0b0
@DeshErBojhaa DeshErBojhaa marked this pull request as draft April 9, 2025 19:28
@DeshErBojhaa DeshErBojhaa mentioned this pull request Apr 9, 2025
Closed
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 9, 2025

Quality Gate Failed Quality Gate failed for 'ibc-go'

Failed conditions
2 Security Hotspots

See analysis details on SonarQube Cloud

@DeshErBojhaa DeshErBojhaa mentioned this pull request Apr 13, 2025
Merged
10 tasks
@womensrights womensrights linked an issue Apr 13, 2025 that may be closed by this pull request
Packet forward middleware #8269
Closed
@DeshErBojhaa DeshErBojhaa self-assigned this May 7, 2025
DeshErBojhaa and others added 14 commits May 9, 2025 22:16
@DeshErBojhaa @gjermundgaraba @womensrights
e2e: Port tests for packet forward middleware module (#8292)
ae228c4 
---------

Co-authored-by: Gjermund Garaba <[email protected]>
Co-authored-by: Susannah Evans <[email protected]>
@gjermundgaraba @DeshErBojhaa
chore: bump sdk math to 1.5.3 (#8293)
695ee1d
@hungdinh82 @DeshErBojhaa
test(07-tendermint): remove unused expPass in TestSetAndGetParams (#8281
fadf346 
)
@hungdinh82 @gjermundgaraba @DeshErBojhaa
test(08-wasm): replace expPass with expError in TestNewKeeper (#8280)
e665141 
Co-authored-by: Gjermund Garaba <[email protected]>
@gjermundgaraba @DeshErBojhaa
chore: bump go-ethereum to v1.15.8 (#8295)
554de1c
@gjermundgaraba @womensrights @DeshErBojhaa
docs: add versioned docs for v10 (#8279)
76e2ef2 
* delete v9 docs

* add v10.1.x versioned docs

* fix broken links

* more link fixes

---------

Co-authored-by: Susannah Evans <[email protected]>
@vladjdk @gjermundgaraba @DeshErBojhaa
rename total_escrow query path (#8287)
ca1cbdb 
Co-authored-by: Gjermund Garaba <[email protected]>
@gjermundgaraba @DeshErBojhaa
docs: set v10 as default (#8301)
4f48209 
* docs: set v10 as default

* fix migration docs
@damiannolan @gjermundgaraba @DeshErBojhaa
feat: allow scaling of trusting period for client upgrades (#8185)
209f0cd 
* feat: allow scaling of trusting period for client upgrades

* refactor: use sdkmath to avoid floating-point precision issues

* chore: update godocs

* chore: impl feedback and add dedicated test case

---------

Co-authored-by: Gjermund Garaba <[email protected]>
@gjermundgaraba @DeshErBojhaa
chore: prep v10.2.x mergify (#8305)
187fdf3
@hungdinh82 @gjermundgaraba @DeshErBojhaa
chore: fix test TestSetGetTotalEscrowForDenom, use expected errors (#…
e48f6df 
…8282)

* fix TestSetGetTotalEscrowForDenom

* fix TestSetGetTotalEscrowForDenom

* add comment to explain where is panic

* test(transfer): construct Coin manually to test SetTotalEscrowForDenom panic logic

* lint

---------

Co-authored-by: Gjermund Garaba <[email protected]>
@gjermundgaraba @DeshErBojhaa
chore: bump deps (#8304)
580420c 
* chore: bump deps

* no go 1.24 plz

* fix docker filer go version
@gjermundgaraba @DeshErBojhaa
chore: remove datahash from ica account creation (#8307)
11f5a79
@aljo242 @DeshErBojhaa
feat: sdk v53 upgrade (#8254)
093b44f 
* update

* preblocker
@DeshErBojhaa DeshErBojhaa mentioned this pull request May 14, 2025
Open
@gjermundgaraba gjermundgaraba mentioned this pull request May 15, 2025
Open
gjermundgaraba
gjermundgaraba approved these changes May 15, 2025
View reviewed changes
Copy link
Contributor

@gjermundgaraba gjermundgaraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woho! I think we are getting ready to merge this bad boy 🙌
I'll let the tests pass and merge it afterwards 🚀

@gjermundgaraba gjermundgaraba merged commit 9ccab29 into main May 15, 2025
52 checks passed
@gjermundgaraba gjermundgaraba deleted the tamjid/pfm-homecoming branch May 15, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjermundgaraba gjermundgaraba gjermundgaraba approved these changes

@womensrights womensrights Awaiting requested review from womensrights womensrights is a code owner

@srdtrk srdtrk Awaiting requested review from srdtrk srdtrk is a code owner

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

Assignees

@DeshErBojhaa DeshErBojhaa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Packet forward middleware