Skip to content

feat: Prefix-based routing in IBCv2 Router #8303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: Prefix-based routing in IBCv2 Router #8303

wants to merge 3 commits into from

Conversation

kulikthebird
Copy link

Description

This PR introduces a prefix-based routing for the IBCv2 Router. Before this change only the exact port IDs could be associated with a given IBCModule. This change make it possible to associate port ID prefixes with the modules.

closes: #8302

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@kulikthebird kulikthebird changed the title feat: feat: Prefix-based routing in IBCv2 Router Apr 15, 2025
@kulikthebird kulikthebird mentioned this pull request Apr 15, 2025
Open
@kulikthebird kulikthebird force-pushed the tkulik/feat/prefix_based_routing_ibcv2 branch from 8032f27 to 434610f Compare April 16, 2025 10:42
AdityaSripal
AdityaSripal reviewed Apr 16, 2025
View reviewed changes
Copy link
Member

@AdityaSripal AdityaSripal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have some way to ensure that there is no portID that is a prefix of another portID?

@kulikthebird kulikthebird force-pushed the tkulik/feat/prefix_based_routing_ibcv2 branch from 6d5ffb8 to 717d783 Compare April 18, 2025 13:10
@kulikthebird
Copy link
Author

Should we have some way to ensure that there is no portID that is a prefix of another portID?

Good point - I've added a check for that and updated the interface a little bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjermundgaraba gjermundgaraba Awaiting requested review from gjermundgaraba gjermundgaraba is a code owner

@srdtrk srdtrk Awaiting requested review from srdtrk srdtrk is a code owner

@womensrights womensrights Awaiting requested review from womensrights womensrights is a code owner

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prefix-based routing in IBCv2 Router
2 participants
@kulikthebird @AdityaSripal