Skip to content

refactor: use pointer receivers consistently for 08-wasm keeper methods #8312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

VolodymyrBg
Copy link

Description

This PR makes the receiver types consistent across keeper method definitions in the light-clients/08-wasm module. All methods now use pointer receivers instead of a mix of pointer and value receivers.

closes: #6165

Changes

  • Updated all Keeper methods in keeper.go to use pointer receivers
  • Updated QueryPlugins methods in querier.go to use pointer receivers
  • Updated test wrapper methods in export_test.go to use pointer receivers

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/). (N/A - code refactoring only)
  • Added relevant godoc comments. (N/A - no new functions)
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@faddat
Copy link
Contributor

faddat commented Apr 17, 2025

thank you for improving consistency!

It's super helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Be consistent with receiver type on method definitions
2 participants